Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag mosh 1.4.0 Release Candidate #1216

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

achernya
Copy link
Collaborator

@achernya achernya commented Aug 4, 2022

No description provided.

@achernya achernya merged commit 7d2601d into mobile-shell:master Aug 4, 2022
@achernya achernya deleted the tag-rc branch August 4, 2022 00:14
@keithw
Copy link
Member

keithw commented Aug 4, 2022

I'm a little nervous about what some of the PPA autobuilds will do with this version number -- are we sure that when 1.4.0 comes out, it will sort later than the packages autobuilt from 1.4.0-rc0 ? I think historically we've done 1.3.99-rc and stuff like that.

@achernya
Copy link
Collaborator Author

achernya commented Aug 4, 2022

We checked with what was done for 1.3, and you can see we have the following tags:

$ git tag -l | grep 1.3
mosh-1.1.3
mosh-1.3.0
mosh-1.3.0-rc0
mosh-1.3.0-rc1
mosh-1.3.0-rc2
mosh-1.3.1-rc2
mosh-1.3.1-rc3
mosh-1.3.2

@keithw
Copy link
Member

keithw commented Aug 4, 2022

Didn't we screw it up somehow and that's why we had to skip a version number? :-)

@achernya
Copy link
Collaborator Author

achernya commented Aug 4, 2022

I don't remember :/. I'm happy to insert the tilde so it "just works". @bbarenblat thoughts?

@bbarenblat
Copy link
Contributor

I think the most correct way forward here is to use a versionmangle stanza in debian/watch to s/-rc/~rc/. But that only works if the PPA autobuilders are actually paying attention to debian/watch, and I don’t know if they are (I’ve never released anything through a PPA). In any case, I’m not opposed to just using the tilde.

@eminence
Copy link
Member

eminence commented Aug 4, 2022

Using the sort-dctrl tool, I sorted a few different versions, and I confirm that the hyphen in something (like 1.4.0-rc0) is problematic. According to sort-dctrl -k Version:v, the following is the sorted order for a few versions I tried:

Version: 1.3.0
Version: 1.3.1
Version: 1.3.1-rc0
Version: 1.3.1-rc1
Version: 1.3.2~rc0
Version: 1.3.2~rc1
Version: 1.3.2
Version: 1.4.0-0~rc0
Version: 1.4.0-0~rc1
Version: 1.4.0-0
Version: 1.4.0-1
Version: 1.4.1-0

@keithw
Copy link
Member

keithw commented Aug 4, 2022

Here is the PPA autobuilder in question: https://code.launchpad.net/~keithw/+recipe/mosh-dev-git

I just changed it to "build on request" until we get square on this.

(The original bzr PPAs are stalled because of a Launchpad bug preventing auto-import of our Git repository after a 2017 merge commit; https://bugs.launchpad.net/bzr-git/+bug/1313861 . I'm hoping we can switch people over to the Git-based PPAs, which maybe can take over the old names.)

@keithw
Copy link
Member

keithw commented Aug 4, 2022

It looks like our historical practice before 1.3.x was to name these like "1.2.3.95rc1" (1.2.4 release candidate) for this reason. I'm not opposed to 1.4.0-rc0, but it looks like we'll need to change the git-build-recipe recipe first or else I think we're burning the ability to release "1.4.0" later.

@eminence
Copy link
Member

eminence commented Aug 5, 2022

Just updating the thread posterity: This commit has been superseded by f3665fb

@eminence eminence added this to the 1.4.0 milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants