Add the ability to specify additional connection options #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if you need to specify `ssl: { verify: false }` in order to get
around a cerificate problem (which I don't recommend, but might be a stopgap),
you may specify when configuring:
```ruby
config.connection_options = { ssl: { verify: false } }
```
This will accept any of faraday's options. See https://github.com/lostisland/faraday/blob/master/lib/faraday/connection.rb
|
This looks good, thanks! I will get this merged and push out a release sometime soon. Also changelog is a great idea. I will add that and attempt to add the changes from previous releases as much as I can as well as some notes for this change. Otherwise I was trying to use semantic versioning as a reasonable approximation of when there might be a breaking change for users. As far as hash syntax goes, we don't have any requirements for that since we only support back to ruby 1.9.3 which has both hash syntaxes anyway. |
|
@jhanggi just released this change as v2.1.0. Thanks for the PR! 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if you need to specify
ssl: { verify: false }in order to getaround a cerificate problem (which I don't recommend, but might be a stopgap),
you may specify when configuring:
This will accept any of faraday's options. See https://github.com/lostisland/faraday/blob/master/lib/faraday/connection.rb
I didn't see a changelog, so I wasn't sure how you wanted to handle what might be a breaking change for some people. In theory, it shouldn't break anything--and should just make everyone a little more secure--because the certificates should be valid, but there's a chance there's some certificate out there that isn't.
Also, I looked but didn't see any examples of your preferred hash syntax, so if it needs to support older
=>, that's an easy change. And I'm not fluent in minitest (I spend most of my life in rspec), so if there's a preferred idiom, I'm happy to change it.Addresses Issue #3.