-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Verifier
s to be passed in the evidence
#11
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 95.15% 90.67% -4.48%
==========================================
Files 2 2
Lines 227 236 +9
==========================================
- Hits 216 214 -2
- Misses 11 22 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good to me - changes might not be needed, but there were some comments for your consideration.
a276890
to
bd8b8ba
Compare
This also changed the `ReportBodyVerifier` to use a builder pattern for the fields to verify.
bd8b8ba
to
cce9f79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I thought we'd decided we were going to have Verifier always take AttestationEvidence
?
We had originally, however since I got it working with generics I figured it would be better to keep it generic unless we run into issues. |
This also changed the
ReportBodyVerifier
to use a builder pattern forthe fields to verify.