Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QE identity verification to EvidenceVerifier #129

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Jul 12, 2023

The EvidenceVerifier now verifies the signed QE identity data as well
as the QE report body's identity

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jul 12, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the size/L Large PRs label Jul 12, 2023
@meowblecoinbot meowblecoinbot requested a review from a team July 12, 2023 22:46
@github-actions
Copy link

github-actions bot commented Jul 12, 2023

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags
yare 1.0.2 0 89 11 0 ____
mc-sgx-dcap-sys-types 0.7.0 0 124 4 0 CB__
assert_matches 1.5.0 0 209 85 0 ____
mc-sgx-core-sys-types 0.7.0 0 226 5 0 CB__
subtle 2.5.0 0 440 148 9 ____
hex 0.4.3 0 474 147 0 ____
displaydoc 0.2.4 0 600 59 20 ____
x509-cert 0.2.3 0 1963 6 0 ____
textwrap 0.16.0 0 2234 73 0 ____
mc-sgx-core-types 0.7.0 0 2255 1 0 ____
p256 0.13.2 0 2545 25 0 ____
mc-sgx-dcap-types 0.7.0 0 2587 0 12 ____
rand 0.8.5 0 5273 65 32 ____
der 0.7.7 0 7848 24 0 ____
serde 1.0.171 0 10534 49 5 CB__
serde_json 1.0.100 0 12167 42 7 CB__

The `EvidenceVerifier` now verifies the signed QE identity data as well
as the QE report body's identity
@nick-mobilecoin nick-mobilecoin changed the base branch from main to nick/lockfile July 12, 2023 23:11
@nick-mobilecoin nick-mobilecoin mentioned this pull request Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #129 (28ac513) into nick/lockfile (48c3027) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           nick/lockfile     #129      +/-   ##
=================================================
+ Coverage          98.15%   98.27%   +0.11%     
=================================================
  Files                 13       13              
  Lines               4068     4169     +101     
=================================================
+ Hits                3993     4097     +104     
+ Misses                75       72       -3     
Impacted Files Coverage Δ
verifier/src/evidence.rs 96.38% <100.00%> (+1.13%) ⬆️
verifier/src/qe_identity.rs 98.45% <100.00%> (+0.06%) ⬆️
verifier/src/qe_report_body.rs 99.23% <100.00%> (ø)
verifier/src/tcb.rs 98.98% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team July 12, 2023 23:19
Base automatically changed from nick/lockfile to main July 12, 2023 23:19
verifier/src/evidence.rs Show resolved Hide resolved
@nick-mobilecoin nick-mobilecoin merged commit 9d1b8f1 into main Jul 13, 2023
39 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/really-add-qe-identity branch July 13, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants