Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quote3Verifier into the EvidenceVerifier #132

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Jul 13, 2023

The EvidenceVerifier will now verify the quote signature using a
Quote3Verifier.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jul 13, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags
yare 1.0.2 0 89 11 0 ____
mc-sgx-dcap-sys-types 0.7.1 0 124 4 0 CB__
assert_matches 1.5.0 0 209 86 0 ____
mc-sgx-core-sys-types 0.7.1 0 226 5 0 CB__
subtle 2.5.0 0 440 149 9 ____
hex 0.4.3 0 474 147 0 ____
displaydoc 0.2.4 0 600 59 20 ____
x509-cert 0.2.3 0 1963 6 0 ____
textwrap 0.16.0 0 2234 73 0 ____
mc-sgx-core-types 0.7.1 0 2284 1 0 ____
p256 0.13.2 0 2545 25 0 ____
mc-sgx-dcap-types 0.7.1 0 2596 0 12 ____
rand 0.8.5 0 5273 65 32 ____
der 0.7.6 0 7820 24 0 ____
serde 1.0.164 0 10262 49 5 CB__
serde_json 1.0.99 0 12167 42 7 CB__

@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team July 13, 2023 16:38
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #132 (a659e22) into main (7ca3371) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head a659e22 differs from pull request most recent head 13d95e8. Consider uploading reports for the commit 13d95e8 to get more accurate results

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   98.44%   98.54%   +0.10%     
==========================================
  Files          13       13              
  Lines        4235     4322      +87     
==========================================
+ Hits         4169     4259      +90     
+ Misses         66       63       -3     
Impacted Files Coverage Δ
verifier/src/evidence.rs 98.20% <100.00%> (+0.61%) ⬆️
verifier/src/quote.rs 97.95% <100.00%> (+0.45%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

The `EvidenceVerifier` will now verify the quote signature using a
`Quote3Verifier`.
verifier/src/quote.rs Show resolved Hide resolved
@nick-mobilecoin nick-mobilecoin merged commit 712838e into main Jul 13, 2023
19 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/add-quote-signature branch July 13, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants