Tests for 4.1.x of PKITS

[nick-mobilecoin]

Fill in the tests for section 4.1 of PKITS.
The tests for 4.1.4-4.1.6 have been omitted as they refer to DSA which
has been deprecated, see
https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-5-draft.pdf#%5B%7B%22num%22%3A72%2C%22gen%22%3A0%7D%2C%7B%22name%22%3A%22XYZ%22%7D%2C72%2C721%2Cnull%5D

Motivation

[nick-mobilecoin]

Current dependencies on/for this PR:

• main
  • PR Move x509 cert logic to sub-directory #68
    • PR Add CRL decode and verification #69
      • PR Add logic to verify and get signing key from chain #70
        • PR Add initial CRL logic to cert chain verification #71
          • PR Add support for RSA X509 certificates #72
            • PR Tests for 4.1.x of PKITS #73 👈
              • PR Convert PKITS tests to integration tests #75
                • PR Tests for 4.2 of PKITS #76
                  • PR Add RFC5280 DistinguishedName behavior #77
                  • PR Add tests for section 4.3 of PKITS #78
                  • PR Make PKITS test support functions more ergonomic. #82

This comment was auto-generated by Graphite.

[github-actions]

❌ Unreviewed dependencies found

Crate	Version	Reviews (N/2)	LoC	Left-Pad Index	Geiger	Flags

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (nick/rsa-certificate@302d2cb). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 702c986 differs from pull request most recent head 5cd3159. Consider uploading reports for the commit 5cd3159 to get more accurate results

@@                   Coverage Diff                   @@
##             nick/rsa-certificate      #73   +/-   ##
=======================================================
  Coverage                        ?   97.93%           
=======================================================
  Files                           ?        8           
  Lines                           ?     2084           
  Branches                        ?        0           
=======================================================
  Hits                            ?     2041           
  Misses                          ?       43           
  Partials                        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[varsha888]

Could you give me more context on PKITS and whats 4.1.1, 4.1.2 and 4.1.3 ?

[nick-mobilecoin]

Could you give me more context on PKITS and whats 4.1.1, 4.1.2 and 4.1.3 ?

Good call out. I was too deep into what I was doing and this PR by itself doesn't have that context.

In #75 I moved this out to an integration test and put the following at the top of the file. Let me know if this suffices or if there should be more context in the resultant test file.

//! Test for section 4.1 of the PKI test suite.
//! https://csrc.nist.gov/projects/pki-testing
//!
//! Tests 4.1.4 - 4.1.6 are not implemented because DSA has been deprecated, see
//! https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-5-draft.pdf#%5B%7B%22num%22%3A72%2C%22gen%22%3A0%7D%2C%7B%22name%22%3A%22XYZ%22%7D%2C72%2C721%2Cnull%5D

[nick-mobilecoin]

punting on implementing x509 chain parsing logic.