Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow merge commits #25

Merged
merged 1 commit into from May 5, 2023
Merged

Allow merge commits #25

merged 1 commit into from May 5, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

Previously merge commits were disallowed. When using stacked PRs, if
initial PR uses a squash merge, git and github loose the information
associate the initial commits in subsequent PRs as belonging to the
initial PR. This results in github saying there are merge conflicts.
Using merge commits allows github to better keep track of which its are
unique to each PR.

Motivation

Previously merge commits were disallowed. When using stacked PRs, if
initial PR uses a squash merge, git and github loose the information
associate the initial commits in subsequent PRs as belonging to the
initial PR. This results in github saying there are merge conflicts.
Using merge commits allows github to better keep track of which its are
unique to each PR.
@nick-mobilecoin
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the size/XS Extra-Small PRs label May 5, 2023
@meowblecoinbot meowblecoinbot requested a review from a team May 5, 2023 16:00
@github-actions
Copy link

github-actions bot commented May 5, 2023

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags
lazy_static 1.4.0 0 134 365 8 ____
mockall_double 0.3.0 0 217 30 0 ____
mockall 0.11.4 0 304 80 0 ____
temp-env 0.3.4 0 385 18 0 ____
displaydoc 0.2.3 0 409 68 24 ____
fluent-asserter 0.1.9 0 737 1 0 ____
walkdir 2.3.3 0 792 107 0 ____
cargo-emit 0.2.1 0 824 10 0 ____
url 2.3.1 0 3639 59 0 ____

@nick-mobilecoin nick-mobilecoin requested a review from a team May 5, 2023 16:02
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@5e652ce). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage        ?   67.48%           
=======================================
  Files           ?        4           
  Lines           ?     1058           
  Branches        ?        0           
=======================================
  Hits            ?      714           
  Misses          ?      344           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin enabled auto-merge (squash) May 5, 2023 16:06
@nick-mobilecoin nick-mobilecoin merged commit bb6b672 into main May 5, 2023
21 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/allow-merge-commits branch May 5, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Extra-Small PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants