Attestation APIs #63
Closed
Attestation APIs #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-mobilecoin
commented
Mar 16, 2023
nick-mobilecoin
commented
Mar 16, 2023
nick-mobilecoin
commented
Mar 16, 2023
nick-mobilecoin
commented
Mar 16, 2023
text/0063-attestation-grpc-apis.md
Outdated
Comment on lines
300
to
303
| Teaclave uses gRPC with a generic payload that is deserialized as JSON, | ||
| <https://teaclave.apache.org/docs/codebase/rpc/>. This limits to one message | ||
| type, which means it limits to clients only needing to know about one service. | ||
| Clients need to deserialize and redirect the message to the correct recipient. |
There was a problem hiding this comment.
This is what we do after attestation. We use a common service for all other requests. Is there good reason to keep attest as a separate service? maybe that should go in the questions section.
There was a problem hiding this comment.
In practice, we will not actually have a separate attest service, because the load balancers can't deal with that.
cbeck88
reviewed
Jun 13, 2023
cbeck88
reviewed
Jun 13, 2023
cbeck88
reviewed
Jun 13, 2023
Co-authored-by: Chris Beck <5683852+cbeck88@users.noreply.github.com>
|
Closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered MCIP