-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aes-gcm from 0.9.4 to 0.10.1 #2806
Conversation
The following labels could not be found: |
❌ Heads up, I tried building full-service using this branch and it failed. |
def9d18
to
9ed17fb
Compare
Changes spawned from RustCrypto/AEADs#436 and RustCrypto/traits#1033 |
9ed17fb
to
cce5dc2
Compare
Bumps [aes-gcm](https://github.com/RustCrypto/AEADs) from 0.9.4 to 0.10.1. - [Release notes](https://github.com/RustCrypto/AEADs/releases) - [Commits](RustCrypto/AEADs@aes-gcm-v0.9.4...aes-gcm-v0.10.1) --- updated-dependencies: - dependency-name: aes-gcm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
cce5dc2
to
52688eb
Compare
- Bump aead from 0.4.3 to 0.5.1 - Bump mc-oblivious-aes-gcm from 0.9.5-pre1 to 0.10.1 - Convert `NewAead` to `KeyInit` - Create a local Aes256Ctr type
@cbeck88 I bumped your review since this ended up making code changes, in particular #2806 (comment) and #2806 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me but I spent like an hour trying to understand the RustCrypto
source enough to convince myself line 105 was correct. I want to suggest a change to the type name so it's now called IvSize
but I'm not actually sure that would be better.
❌ Heads up, I tried building android-bindings using this branch and it failed. |
fce9762
to
cd0444c
Compare
* Bump aes-gcm from 0.9.4 to 0.10.1 Bumps [aes-gcm](https://github.com/RustCrypto/AEADs) from 0.9.4 to 0.10.1. - [Release notes](https://github.com/RustCrypto/AEADs/releases) - [Commits](RustCrypto/AEADs@aes-gcm-v0.9.4...aes-gcm-v0.10.1) --- updated-dependencies: - dependency-name: aes-gcm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updates to support aes-gcm 10.1.0 - Bump aead from 0.4.3 to 0.5.1 - Bump mc-oblivious-aes-gcm from 0.9.5-pre1 to 0.10.1 - Convert `NewAead` to `KeyInit` - Create a local Aes256Ctr type * Update to released version of `mc-oblivious-aes-gcm` Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nick Santana <nick@mobilecoin.com>
* Bump aes-gcm from 0.9.4 to 0.10.1 Bumps [aes-gcm](https://github.com/RustCrypto/AEADs) from 0.9.4 to 0.10.1. - [Release notes](https://github.com/RustCrypto/AEADs/releases) - [Commits](RustCrypto/AEADs@aes-gcm-v0.9.4...aes-gcm-v0.10.1) --- updated-dependencies: - dependency-name: aes-gcm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updates to support aes-gcm 10.1.0 - Bump aead from 0.4.3 to 0.5.1 - Bump mc-oblivious-aes-gcm from 0.9.5-pre1 to 0.10.1 - Convert `NewAead` to `KeyInit` - Create a local Aes256Ctr type * Update to released version of `mc-oblivious-aes-gcm` Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nick Santana <nick@mobilecoin.com>
Bumps aes-gcm from 0.9.4 to 0.10.1.
Commits
2f26128
aes-gcm v0.10.1 (#463)91f4062
Fix rustdoc typos (#462)19cd777
Include README.md in rustdoc (#461)30219d9
Fix rustdoc documentation (#460)2e629af
xsalsa20poly1305 v0.9.0 (#459)829f0df
chacha20poly1305 v0.10.0 (#458)2f1b9be
aes-gcm-siv v0.11.0 (#457)dee96e7
aes-gcm v0.10.0 (#456)f9b0202
README.md(s): use crate badges from buildstats.info (#455)78b0cd7
Bump UHF crates touniversal-hash
v0.5-based releases (#454)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)