Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aes-gcm from 0.9.4 to 0.10.1 #2806

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 1, 2022

Bumps aes-gcm from 0.9.4 to 0.10.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 1, 2022

The following labels could not be found: blocks-v3.x.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

❌ Heads up, I tried building full-service using this branch and it failed.
Build logs can be found by inspecting the github action run Check that repositories submoduling us will still build after this PR / full-service or by clicking here.

@dependabot dependabot bot force-pushed the dependabot/cargo/aes-gcm-0.10.1 branch from def9d18 to 9ed17fb Compare November 1, 2022 19:12
@jcape
Copy link
Contributor

jcape commented Nov 4, 2022

@nick-mobilecoin
Copy link
Collaborator

Changes spawned from RustCrypto/AEADs#436 and RustCrypto/traits#1033

@jcape jcape added the old-v4.0.0 Blocker for v4 label Dec 6, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/aes-gcm-0.10.1 branch from 9ed17fb to cce5dc2 Compare December 6, 2022 18:42
@jcape jcape self-assigned this Dec 6, 2022
@jcape jcape self-requested a review December 6, 2022 20:43
@jcape jcape assigned nick-mobilecoin and unassigned jcape Dec 6, 2022
Bumps [aes-gcm](https://github.com/RustCrypto/AEADs) from 0.9.4 to 0.10.1.
- [Release notes](https://github.com/RustCrypto/AEADs/releases)
- [Commits](RustCrypto/AEADs@aes-gcm-v0.9.4...aes-gcm-v0.10.1)

---
updated-dependencies:
- dependency-name: aes-gcm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/aes-gcm-0.10.1 branch from cce5dc2 to 52688eb Compare December 7, 2022 18:28
- Bump aead from 0.4.3 to 0.5.1
- Bump mc-oblivious-aes-gcm from 0.9.5-pre1 to 0.10.1
- Convert `NewAead` to `KeyInit`
- Create a local Aes256Ctr type
Cargo.toml Outdated Show resolved Hide resolved
@nick-mobilecoin
Copy link
Collaborator

nick-mobilecoin commented Dec 9, 2022

@cbeck88 I bumped your review since this ended up making code changes, in particular #2806 (comment) and #2806 (comment)

Copy link
Contributor

@cbeck88 cbeck88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you

@jcape jcape added ! v5.0.0 Blocker for v5 and removed old-v4.0.0 Blocker for v4 labels Dec 14, 2022
@jcape jcape requested a review from awygle January 4, 2023 18:23
Copy link
Contributor

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me but I spent like an hour trying to understand the RustCrypto source enough to convince myself line 105 was correct. I want to suggest a change to the type name so it's now called IvSize but I'm not actually sure that would be better.

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

❌ Heads up, I tried building android-bindings using this branch and it failed.
Build logs can be found by inspecting the github action run Check that repositories submoduling us will still build after this PR / android-bindings or by clicking here.

@nick-mobilecoin nick-mobilecoin merged commit 4ed05a4 into master Jan 6, 2023
@dependabot dependabot bot deleted the dependabot/cargo/aes-gcm-0.10.1 branch January 6, 2023 21:09
briancorbin pushed a commit that referenced this pull request Jan 23, 2023
* Bump aes-gcm from 0.9.4 to 0.10.1

Bumps [aes-gcm](https://github.com/RustCrypto/AEADs) from 0.9.4 to 0.10.1.
- [Release notes](https://github.com/RustCrypto/AEADs/releases)
- [Commits](RustCrypto/AEADs@aes-gcm-v0.9.4...aes-gcm-v0.10.1)

---
updated-dependencies:
- dependency-name: aes-gcm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updates to support aes-gcm 10.1.0

- Bump aead from 0.4.3 to 0.5.1
- Bump mc-oblivious-aes-gcm from 0.9.5-pre1 to 0.10.1
- Convert `NewAead` to `KeyInit`
- Create a local Aes256Ctr type

* Update to released version of `mc-oblivious-aes-gcm`

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
briancorbin pushed a commit to ryankurte/mobilecoin that referenced this pull request Jan 23, 2023
* Bump aes-gcm from 0.9.4 to 0.10.1

Bumps [aes-gcm](https://github.com/RustCrypto/AEADs) from 0.9.4 to 0.10.1.
- [Release notes](https://github.com/RustCrypto/AEADs/releases)
- [Commits](RustCrypto/AEADs@aes-gcm-v0.9.4...aes-gcm-v0.10.1)

---
updated-dependencies:
- dependency-name: aes-gcm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updates to support aes-gcm 10.1.0

- Bump aead from 0.4.3 to 0.5.1
- Bump mc-oblivious-aes-gcm from 0.9.5-pre1 to 0.10.1
- Convert `NewAead` to `KeyInit`
- Create a local Aes256Ctr type

* Update to released version of `mc-oblivious-aes-gcm`

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code ! v5.0.0 Blocker for v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants