-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump grpcio from 0.11.0 to 0.12.0 #2826
Conversation
e9dc395
to
3f180fa
Compare
3f180fa
to
354d3cb
Compare
It looks like CI is failing because |
Bumps [grpcio](https://github.com/tikv/grpc-rs) from 0.11.0 to 0.12.0. - [Release notes](https://github.com/tikv/grpc-rs/releases) - [Changelog](https://github.com/tikv/grpc-rs/blob/master/CHANGELOG.md) - [Commits](https://github.com/tikv/grpc-rs/commits) --- updated-dependencies: - dependency-name: grpcio dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
354d3cb
to
9e1db31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would be nice to replace all the unwrap()
with expect()
, but not super necessary.
Remove more unwraps from test code Co-authored-by: James Cape <james@mobilecoin.com>
✅ Good job, android-bindings was built successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
* Bump grpcio from 0.11.0 to 0.12.0 Bumps [grpcio](https://github.com/tikv/grpc-rs) from 0.11.0 to 0.12.0. - [Release notes](https://github.com/tikv/grpc-rs/releases) - [Changelog](https://github.com/tikv/grpc-rs/blob/master/CHANGELOG.md) - [Commits](https://github.com/tikv/grpc-rs/commits) --- updated-dependencies: - dependency-name: grpcio dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update Mobilecoin code to GRPCIO 0.12 API * Don't use unwrap in GRPC test code * Apply suggestions from code review Remove more unwraps from test code Co-authored-by: James Cape <james@mobilecoin.com> * Fix small errors Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Wygle <andrew@mobilecoin.com> Co-authored-by: James Cape <james@mobilecoin.com>
* Bump grpcio from 0.11.0 to 0.12.0 Bumps [grpcio](https://github.com/tikv/grpc-rs) from 0.11.0 to 0.12.0. - [Release notes](https://github.com/tikv/grpc-rs/releases) - [Changelog](https://github.com/tikv/grpc-rs/blob/master/CHANGELOG.md) - [Commits](https://github.com/tikv/grpc-rs/commits) --- updated-dependencies: - dependency-name: grpcio dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update Mobilecoin code to GRPCIO 0.12 API * Don't use unwrap in GRPC test code * Apply suggestions from code review Remove more unwraps from test code Co-authored-by: James Cape <james@mobilecoin.com> * Fix small errors Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Wygle <andrew@mobilecoin.com> Co-authored-by: James Cape <james@mobilecoin.com>
Bumps grpcio from 0.11.0 to 0.12.0.
Changelog
Sourced from grpcio's changelog.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)