Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpcio from 0.11.0 to 0.12.0 #2826

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2022

Bumps grpcio from 0.11.0 to 0.12.0.

Changelog

Sourced from grpcio's changelog.

0.12.0 - 2022-11-04

  • Update prost to 0.11 (#595)
  • Update grpc to 1.36.5 (#593)
  • Update the security API of channel to match the C++ version (#593)

Note, 1.36.5 removes the support of epollex engine (which is the default engine before), and enables transparent retry by default. So you may experience potential performance regression. And 1.36.5 is also the last version that supports C++11. Next version will requires C++14.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added old-v4.0.0 Blocker for v4 dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 4, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/grpcio-0.12.0 branch 2 times, most recently from e9dc395 to 3f180fa Compare November 22, 2022 15:23
@dependabot dependabot bot force-pushed the dependabot/cargo/grpcio-0.12.0 branch from 3f180fa to 354d3cb Compare December 6, 2022 18:42
@jcape jcape assigned jcape and awygle and unassigned jcape Dec 6, 2022
@jcape jcape requested review from jcape and NotGyro December 6, 2022 20:47
@NotGyro
Copy link
Contributor

NotGyro commented Dec 7, 2022

It looks like CI is failing because Server's bind_addrs method, ChannelBuilder's secure_connect method, and ServerBuilder's bind() and bind_with_fetcher methods either no longer exist or are no longer in scope. @awygle

Bumps [grpcio](https://github.com/tikv/grpc-rs) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/tikv/grpc-rs/releases)
- [Changelog](https://github.com/tikv/grpc-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tikv/grpc-rs/commits)

---
updated-dependencies:
- dependency-name: grpcio
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/grpcio-0.12.0 branch from 354d3cb to 9e1db31 Compare December 7, 2022 18:28
fog/report/server/src/server.rs Show resolved Hide resolved
util/grpc/src/grpcio_extensions.rs Show resolved Hide resolved
util/grpc/src/lib.rs Show resolved Hide resolved
Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be nice to replace all the unwrap() with expect(), but not super necessary.

consensus/service/src/api/attested_api_service.rs Outdated Show resolved Hide resolved
consensus/service/src/api/blockchain_api_service.rs Outdated Show resolved Hide resolved
consensus/service/src/api/client_api_service.rs Outdated Show resolved Hide resolved
consensus/service/src/api/peer_api_service.rs Outdated Show resolved Hide resolved
consensus/service/src/consensus_service.rs Outdated Show resolved Hide resolved
util/grpc/src/lib.rs Outdated Show resolved Hide resolved
util/grpc/src/lib.rs Outdated Show resolved Hide resolved
util/grpc/src/server_cert_reloader.rs Outdated Show resolved Hide resolved
util/grpc/src/server_cert_reloader.rs Show resolved Hide resolved
watcher/src/bin/main.rs Outdated Show resolved Hide resolved
@jcape jcape added ! v5.0.0 Blocker for v5 and removed old-v4.0.0 Blocker for v4 labels Dec 14, 2022
awygle and others added 3 commits December 15, 2022 10:26
Remove more unwraps from test code

Co-authored-by: James Cape <james@mobilecoin.com>
@github-actions
Copy link

✅ Good job, android-bindings was built successfully.
Build logs can be found by inspecting the github action run Check that repositories submoduling us will still build after this PR / android-bindings or by clicking here.

Copy link
Contributor

@NotGyro NotGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@awygle awygle merged commit 6cc3678 into master Jan 5, 2023
@dependabot dependabot bot deleted the dependabot/cargo/grpcio-0.12.0 branch January 5, 2023 04:26
briancorbin pushed a commit that referenced this pull request Jan 23, 2023
* Bump grpcio from 0.11.0 to 0.12.0

Bumps [grpcio](https://github.com/tikv/grpc-rs) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/tikv/grpc-rs/releases)
- [Changelog](https://github.com/tikv/grpc-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tikv/grpc-rs/commits)

---
updated-dependencies:
- dependency-name: grpcio
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update Mobilecoin code to GRPCIO 0.12 API

* Don't use unwrap in GRPC test code

* Apply suggestions from code review

Remove more unwraps from test code

Co-authored-by: James Cape <james@mobilecoin.com>

* Fix small errors

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Wygle <andrew@mobilecoin.com>
Co-authored-by: James Cape <james@mobilecoin.com>
briancorbin pushed a commit to ryankurte/mobilecoin that referenced this pull request Jan 23, 2023
* Bump grpcio from 0.11.0 to 0.12.0

Bumps [grpcio](https://github.com/tikv/grpc-rs) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/tikv/grpc-rs/releases)
- [Changelog](https://github.com/tikv/grpc-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tikv/grpc-rs/commits)

---
updated-dependencies:
- dependency-name: grpcio
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update Mobilecoin code to GRPCIO 0.12 API

* Don't use unwrap in GRPC test code

* Apply suggestions from code review

Remove more unwraps from test code

Co-authored-by: James Cape <james@mobilecoin.com>

* Fix small errors

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Wygle <andrew@mobilecoin.com>
Co-authored-by: James Cape <james@mobilecoin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code ! v5.0.0 Blocker for v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants