Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust to 2023-01-04 #2999

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Update rust to 2023-01-04 #2999

merged 8 commits into from
Feb 2, 2023

Conversation

samdealy
Copy link
Contributor

@samdealy samdealy commented Jan 10, 2023

Motivation

The repo is currently using of the nightly-2022-04-29 version of rust. This is problematic because it prevents us from using some of the latest features (e.g. #2965). This PR updates Rust and fixes a few clippy errors such as:

  • Inline text formatting
  • Result error variant too large: note, we disabled this lint because we don't want to introduce an alloc and the change is pretty substantial (you have to Box a lot of errors and are therefore unable to destructure inner error fields because Box is an opaque type, thus decreasing readability)
  • Removal of unnecssary clone or references that clippy didn't catch previously.

If you see any instances of changes outside of those outlined above, feel free to leave a comment and I'll double check that it should be included.

Future Work

  • Update repos that use mobilecoin.git as a submodule.

@samdealy samdealy changed the title Sam/update rust master Update rust to 2023-01-04 #2986 Jan 10, 2023
@samdealy samdealy self-assigned this Jan 10, 2023
@samdealy samdealy linked an issue Jan 10, 2023 that may be closed by this pull request
@samdealy samdealy added the rust Pull requests that update Rust code label Jan 10, 2023
@samdealy samdealy changed the title Update rust to 2023-01-04 #2986 Update rust to 2023-01-04 Jan 10, 2023
@samdealy samdealy added ! v5.0.0 Blocker for v5 rust-update Area: rust updates tech-debt Technical debt payment and removed rust-update Area: rust updates labels Jan 10, 2023
@samdealy samdealy marked this pull request as ready for review February 2, 2023 01:37
Copy link
Contributor

@cbeck88 cbeck88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

attest/ake/src/lib.rs Show resolved Hide resolved
@samdealy samdealy merged commit a6092d9 into master Feb 2, 2023
@samdealy samdealy deleted the sam/update-rust-master branch February 2, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code tech-debt Technical debt payment ! v5.0.0 Blocker for v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update Rust Nightly to something more recent...
3 participants