Defragmentation Memos #3170
Merged
Defragmentation Memos #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Good job, full-service was built successfully. |
jcape
requested review from
a team,
NotGyro and
samdealy
and removed request for
a team
nick-mobilecoin
approved these changes
Mar 7, 2023
transaction/builder/src/memo_builder/defragmentation_memo_builder.rs
Outdated
Show resolved
Hide resolved
transaction/builder/src/memo_builder/defragmentation_memo_builder.rs
Outdated
Show resolved
Hide resolved
transaction/builder/src/memo_builder/defragmentation_memo_builder.rs
Outdated
Show resolved
Hide resolved
NotGyro
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
This looks good to go to me, so long as the issues @nick-mobilecoin has already identified are resolved.
…der.rs Co-authored-by: Nick Santana <nick@mobilecoin.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
…der.rs Co-authored-by: Nick Santana <nick@mobilecoin.com>
…der.rs Co-authored-by: Nick Santana <nick@mobilecoin.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
|
✅ Good job, full-service was built successfully. |
Co-authored-by: Nick Santana <nick@mobilecoin.com>
…der.rs Co-authored-by: Nick Santana <nick@mobilecoin.com>
…der.rs Co-authored-by: Nick Santana <nick@mobilecoin.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
Co-authored-by: Nick Santana <nick@mobilecoin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements changes outlined in MCIP #61.
MCIP #61 proposes a new memo type: the defragmentation memo. This memo type is used to denote defragmentation transactions. It also includes an ID field that can be used to easily group together multiple rounds of one defragmentation session together for the purpose of reporting total paid in fees and total amount defragmented. The full implementation details and rationale for defragmentation memos can be found here.