-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing extra GRPC services to AdminServer #3242
Conversation
A bunch of our applications already include this internal, privileged GRPC server, and it could be convenient to use it for extra app-specific functionality.
If you want this for deqs repo, are you going to bump deqs repo to point at master? |
Oops yeah this should be against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me
This should be pointed at master: we haven't done any testing on this at all, it wasn't brought up in any meeting, and we're releasing in < 6 hours. 5.0 is (tentatively) scheduled for release on Monday, there's literally zero point to put this into the stable branch at this late a stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's too late to add new features to 4.1.
Maybe we can do a 4.1+dev branch for the deqs so that we arent building against master for prod? |
I don't remember whats getting into 5.0 but maybe we can just move the DEQS to point at 5? |
The current plan is for
|
Im not asking to push back It also may be fine to bump deqs to 5, im not sure. But id like to demo it soon against testnet and i expect there may be breaking changes in 5 |
Motivation
A bunch of our applications already include this internal, privileged GRPC server, and it could be convenient to use it for extra app-specific functionality.
Specifically, I want to add some admin commands to the DEQS liquidity bot, and it already has this GRPC server, so it seemed like the right place for it, but at the moment there's no way to add extra GRPC services so I either copy-paste
AdminServer
, or we extend it to allow passing of extra GRPC services.