Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include necessary optional dep when the serde feature is enabled #3303

Merged
merged 1 commit into from
Apr 5, 2023
Merged

include necessary optional dep when the serde feature is enabled #3303

merged 1 commit into from
Apr 5, 2023

Conversation

eranrund
Copy link
Contributor

@eranrund eranrund commented Apr 5, 2023

Motivation

https://github.com/mobilecoinfoundation/mobilecoin/blob/master/crypto/keys/src/ed25519.rs#L40-L41 gates a use statement for the mc_util_serial crate behind the serde feature, but the serde feature as currently configured in this crate's Cargo.toml does not include the mc_util_serial crate when enabled.

@jcape jcape requested a review from samdealy April 5, 2023 01:14
@eranrund eranrund merged commit f4fdb22 into master Apr 5, 2023
@eranrund eranrund deleted the fix-optional-crypto-keys-dep branch April 5, 2023 03:28
NotGyro pushed a commit that referenced this pull request Apr 7, 2023
@eranrund @NotGyro
include necessary optional dep when the serde feature is enabled (#3303)
31455af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcape jcape jcape approved these changes

@cbeck88 cbeck88 cbeck88 approved these changes

@samdealy samdealy Awaiting requested review from samdealy

Assignees

@eranrund eranrund

Labels
None yet
Projects
Core PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eranrund @jcape @cbeck88