Prometheus edit service names #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsha888
requested review from
jgreat,
a team,
jcape,
awygle,
nick-mobilecoin and
samdealy
and removed request for
a team and
jcape
nick-mobilecoin
approved these changes
Apr 21, 2023
jgreat
approved these changes
Apr 21, 2023
varsha888
force-pushed
the
feature/bug_metrics
branch
from
6863120
to
a2b4a29
Compare
awygle
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This issue was because fog service names were same for OpMetrics and ServiceMetrics.
Consensus service has different names for the two metrics.
This PR edits fog service names to be consistent with "consensus_service" in Prometheus.