Update rust-toolchain to toml format #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the rust-toolchain file was using the legacy one line toolchain version format from <https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file>. Now the rust-toolchain file uses toml format and updates the nightly version to the last nightly that contained 1.68
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
requested review from
a team,
samdealy and
varsha888
and removed request for
a team
nick-mobilecoin
commented
Apr 21, 2023
|
you can see a dependabot run using the same toolchain file at https://github.com/nick-mobilecoin/rust-buf-build/network/updates |
cbeck88
approved these changes
Apr 21, 2023
wjuan-mob
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the rust-toolchain file was using the legacy one line toolchain version format from https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file. Now the rust-toolchain file uses toml format and updates the nightly version to the last nightly that contained 1.68.
Motivation
Dependabot has been updated to only read the toml format of the rust-toolchain file.
Keeping the changes targeted on the dependabot fix, the rust-toolchain file was not renamed to the newer
rust-toolchain.toml.The nightly version was bumped to the last nightly that was 1.68. This was to bring in the https/sparse crates.io logic that came in 1.68 which dependabot relies on for 1.68 toolchain versions. This was only moved a little to minimize other clippy and format changes that might be needed.
For reference the nightly dates and version transitions:
2023-01-04 was the previous nightly version used.