Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Attributes form mc-sgx-core-types #3438

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Jul 21, 2023

Previously the Attributes was defined in mc-attest-core. Now the
Attributes from mc-sgx-core-types is used.

@nick-mobilecoin nick-mobilecoin mentioned this pull request Jul 21, 2023
15 tasks
Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me except me being a bit suspicious about the Ord stuff. Is there anything preventing attributes from deriving it?

attest/core/src/types/report_body.rs Show resolved Hide resolved
Base automatically changed from nick/report-data to master July 25, 2023 14:55
Previously the `Attributes` was defined in `mc-attest-core`. Now the
`Attributes` from `mc-sgx-core-types` is used.
@nick-mobilecoin
Copy link
Collaborator Author

@nick-mobilecoin started a stack merge that includes this pull request via Graphite.

@nick-mobilecoin nick-mobilecoin merged commit a0ce54d into master Jul 25, 2023
20 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/attributes branch July 25, 2023 20:07
@nick-mobilecoin
Copy link
Collaborator Author

@nick-mobilecoin merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants