Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate DCAP quotes in enclaves #3612

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Generate DCAP quotes in enclaves #3612

merged 5 commits into from
Oct 16, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Oct 14, 2023 •
edited

The enclaves now generate DCAP specified quotes, Quote3.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Oct 14, 2023 •
edited

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@nick-mobilecoin
Generate DCAP quotes in enclaves
5d49104 
The enclaves now generate DCAP specified quotes, `Quote3`.
@nick-mobilecoin
Fix tests for identities
e993818
@nick-mobilecoin nick-mobilecoin marked this pull request as ready for review October 14, 2023 20:37
This was referenced Oct 14, 2023
Merged
Merged
Merged
Merged
eranrund
eranrund reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have some very minor nits and small comments regarding the report cache and some expect usage. Thank you!

attest/ake/src/responder.rs Outdated Show resolved Hide resolved
attest/core/README.md Outdated Show resolved Hide resolved
attest/core/README.md Outdated Show resolved Hide resolved
sgx/report-cache/untrusted/src/lib.rs Show resolved Hide resolved
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Oct 16, 2023 •
edited

Merge activity

@nick-mobilecoin nick-mobilecoin merged commit c07b5cd into master Oct 16, 2023
20 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/quote3-from-enclaves branch October 16, 2023 19:20
This was referenced Dec 4, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranrund eranrund eranrund approved these changes

@dolanbernard dolanbernard Awaiting requested review from dolanbernard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nick-mobilecoin @eranrund