Use postgres service in gh actions #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
nick-mobilecoin
changed the title
nick-mobilecoin
force-pushed
the
nick/posgres-ci-service
branch
from
1b4ee36
to
8db9a67
Compare
nick-mobilecoin
force-pushed
the
nick/posgres-ci-service
branch
from
93d2f55
to
2b5309d
Compare
nick-mobilecoin
force-pushed
the
nick/posgres-ci-service
branch
2 times, most recently
from
4827933
to
a9102b1
Compare
nick-mobilecoin
commented
Dec 12, 2023
nick-mobilecoin
commented
Dec 12, 2023
Previously the CI runs would start the postgres service inside of the container doing tests. This would result in intermittent failures when postgres wasn't able to start up. Now a service container is used for postgres as described in https://docs.github.com/en/actions/using-containerized-services/creating-postgresql-service-containers
nick-mobilecoin
force-pushed
the
nick/posgres-ci-service
branch
from
a9102b1
to
89274cc
Compare
This was referenced Dec 13, 2023
jgreat
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the CI runs would start the postgres service inside of the container doing tests. This would result in intermittent failures when postgres wasn't able to start up. Now a service container is used for postgres as described in https://docs.github.com/en/actions/using-containerized-services/creating-postgresql-service-containers.