mobilecoind: include RTH memos by default and allow customizing them if desired #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up that I also have a branch ready for adding T3 reporting, but it is built on top of this branch and Github doesn't have an easy way for me to PR that before this one gets merged (I can't do graphite stacks in a repo I don't have write access to, unless I am missing something). Thanks! |
holtzman
approved these changes
Apr 1, 2024
cbeck88
reviewed
Apr 11, 2024
cbeck88
reviewed
Apr 11, 2024
cbeck88
approved these changes
Apr 11, 2024
holtzman
merged commit 66a2878
into
mobilecoinfoundation:release/v6.0
30 of 50 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now
mobilecoinddoes not include memos in transactions it generates (except burn redemption transactions).full-service, Sentz, and some other clients already include these memos and it would be better ofmobilecoindincludes them as well.I opted to build this in a way that defaults to including the RTH memos unless the user explicitly does not want them. This is in line with
full-serviceand other clients behavior, and simplifies upgrading since existingmobilecoindusers will not need to change anything to start including the memos.