Add .invalidBlockVersion error that can now be thrown by rust FFI's
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plarson
approved these changes
Aug 3, 2022
…on is invalid (to new for rust-lib).
the-real-adammork
force-pushed
the
task/transaction-builder-blockversion-newness-errors
branch
from
a0588e6
to
d04a10f
Compare
the-real-adammork
changed the base branch from
master
to
task/idempotence-release
carybakker
approved these changes
Aug 29, 2022
carybakker
deleted the
task/transaction-builder-blockversion-newness-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A fix was made in the rust code to solve a potential panic if an unknown BlockVersion was passed in as a parameter to the TransactionBuilder. Unknown in this sense equals too "new".
The FFIs are being updated here: mobilecoinfoundation/mobilecoin#2335
libmobilecoin-ios-artifacs here: mobilecoinofficial/libmobilecoin#32
In this PR