Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to Xcode 12.5.1 and fix lint errors #182

Merged
merged 11 commits into from
Aug 18, 2022
Merged

Revert to Xcode 12.5.1 and fix lint errors #182

merged 11 commits into from
Aug 18, 2022

Conversation

plarson
Copy link
Contributor

@plarson plarson commented Aug 18, 2022 •
edited
Loading

Motivation

Xcode 13 has intermittent build failures and the linter has warnings and fails in release.

- WARN  | [MobileCoin/Core,MobileCoin/CoreHTTP] xcodebuild:  MobileCoin/Sources/Fog/Report/FogReportServer.swift:35:82: warning: tuple conversion from '(reportId: String, desiredMinPubkeyExpiry: UInt64)' to '(reportId: String, minPubkeyExpiry: UInt64)' mismatches labels
- WARN  | [MobileCoin/Core,MobileCoin/CoreHTTP] xcodebuild:  MobileCoin/Sources/Fog/Report/FogReportServer.swift:67:86: warning: tuple conversion from '(reportId: String, desiredMinPubkeyExpiry: UInt64)' to '(reportId: String, minPubkeyExpiry: UInt64)' mismatches labels    
[!] The spec did not pass validation, due to 2 warnings (but you can use `--allow-warnings` to ignore them).

In this PR

  • All other forms of this tuple use desiredMinPubkeyExpiry so updated these locations.

@plarson plarson changed the title Fix lint error for mismatched labels Fix lint errors Aug 18, 2022
@plarson plarson changed the title Fix lint errors Fix lint errors and revert Xcode to 12.5.1 Aug 18, 2022
@plarson plarson changed the title Fix lint errors and revert Xcode to 12.5.1 Fix lint errors and revert to Xcode 12.5.1 Aug 18, 2022
@plarson plarson changed the title Fix lint errors and revert to Xcode 12.5.1 Revert to Xcode 12.5.1 and fix lint errors Aug 18, 2022
@plarson plarson merged commit b4af389 into master Aug 18, 2022
@plarson plarson deleted the plarson/desiredMinPubkeyExpiry branch August 18, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-real-adammork the-real-adammork the-real-adammork approved these changes

@carybakker carybakker Awaiting requested review from carybakker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@plarson @the-real-adammork