Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate tests already moved to async #228

Merged
merged 15 commits into from
Feb 11, 2023
Merged

Remove duplicate tests already moved to async #228

merged 15 commits into from
Feb 11, 2023

Conversation

carybakker
Copy link
Contributor

@carybakker carybakker commented Feb 6, 2023 •
edited
Loading

Soundtrack of this PR: Clean Up

Motivation

Remove redundant tests to speed up integration testing

In this PR

  • Removed non-async tests already implemented in asyc form
  • Add logic to pre-populate transactions with all MemoTypes for RTH testing
  • Converted remaining non-async tests async

[Fixes #184383403]

Future Work

  • Continued removal of test redundancy

@carybakker carybakker merged commit d8e4bb9 into master Feb 11, 2023
@carybakker carybakker deleted the 184383403-remove-tests-moved-to-async branch February 11, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-real-adammork the-real-adammork the-real-adammork approved these changes

@plarson plarson Awaiting requested review from plarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carybakker @the-real-adammork