Cary/service url rotation unit tests 184441012 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-real-adammork
requested changes
Feb 18, 2023
added 2 commits
February 20, 2023 17:19
* de-abstracted the tests - moved some logic from fixture into tests * updated config of MockHttpRequester so it's dependency injected by the tests for clarity * renamed MockHttpRequester to MockFailingHttpRequester to clearly communicate its purpose
I didn’t fully collapse the test fixture file (just noticed that comment at the end), but I did put the config code relevant to the tests inline… I think it does what you were looking for in terms of ‘demonstrating’ the intent of the test without bloating the test file with all the config of the individual service connections |
the-real-adammork
approved these changes
Feb 21, 2023
carybakker
deleted the
cary/service-url-rotation-unit-tests-184441012
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soundtrack of this PR: Converting Units
Motivation
A number of tests that are implemented as Integration Tests should really be handled via Unit Tests. Integration Tests will still handle the holistic testing of functionality, but granular tests for code coverage or specific cases can be more efficiently handled with Unit Tests.
This has become much more important as the amount of time required to execute Integration Tests has increased with the number of Integration Tests implemented, to the point where it impacts out ability to release in a timely manner.
In this PR
Future Work