Priority Queue Implementation for Imogen #76

transfaeries · 2022-01-11T19:40:01Z

To discuss and implement a paid priority queue for imogen.

I will write a possible spec for how it could work, and we can discuss it.

┆Issue is synchronized with this Asana task by Unito

itdaniher

Looks good overall; left a few comments. Didn't read imogen.py too deeply, assuming that it does what you need.

We probably want to make sure this doesn't conflict with any mobfriend behavior / assumptions made by other bots.

forest/core.py

itdaniher · 2022-01-31T23:04:39Z

forest/core.py

@@ -246,6 +264,10 @@ async def handle_auxincli_raw_line(self, line: str) -> None:
                # maybe also send this to admin as a signal message
                for _line in tb:
                    logging.error(_line)
+            if "sender keys" in blob["error"] and self.proc:


🤔 ? this needs comments explaining why, at least

i have absolutely no clue lol

ef491a7

i think there was some error about not being able to receive or find sender keys that made signal-cli hang

itdaniher · 2022-01-31T23:05:08Z

forest/core.py

@@ -316,6 +338,12 @@ async def set_profile_auxin(
        await self.auxincli_input_queue.put(rpc("setProfile", params, future_key))
        return future_key

+    async def save_sent_message(self, rpc_id: str, params: dict[str, str]) -> None:


does this work on auxin? should sent_messages be a pdict or otherwise persisted across resets?

not sure why it wouldn't.

i don't actually need to this anymore because the important timestamps to match are in prompt_queue, beyond maybe keeping track of payments that were made

dunno if this is useful to anyone else, maybe i'll drop it

itdaniher · 2022-01-31T23:05:52Z

forest/core.py

        return future_key

-    async def admin(self, msg: Response) -> None:
-        await self.send_message(utils.get_secret("ADMIN"), msg)
+    async def admin(self, msg: Response, **kwargs: Any) -> None:


looks good; should this be blocked by SIGNAL=signal?

don't understand, isn't it?

forest/core.py

forest/payments_monitor.py

itdaniher · 2022-01-31T23:11:43Z

imogen/Dockerfile

@@ -4,39 +4,35 @@ SHELL ["/usr/bin/bash", "-c"]
 WORKDIR /app
 RUN microdnf install -y git zlib-devel && rm -rf /var/cache/yum
 RUN gu install native-image
-RUN git clone --branch forest-fork https://github.com/forestcontact/signal-cli
+RUN git clone --branch upstream https://github.com/forestcontact/signal-cli


any reason not to swap this to asamk and use a tag?

can't push specific tags to asamk, came up when trying to pick the right senderkeys commit

itdaniher · 2022-01-31T23:13:18Z

imogen/imogen.py

@@ -217,6 +537,38 @@ async def do_c(self, msg: Message) -> str:
        )
        return response["choices"][0]["text"].strip()

+    @hide
+    async def do_ask(self, msg: Message) -> str:


make this invoke the do_gpt handler?

yeah lol this is so stupid, i think the original point of this was that they had different stopwords, but stopwords don't seem to work with instruct-gpt anyway

imogen/imogen.py

itdaniher · 2022-01-31T23:14:16Z

purse/Dockerfile

@@ -0,0 +1,48 @@
+FROM ghcr.io/rust-lang/rust:nightly as builder


is purse used / working? or should this be a separate PR?

it's used but not really working, i should probably fix it before merging this ig; imogen.py uses it

technillogue · 2022-02-01T00:52:53Z

forest/message.py

+    def parse_text(self, text: str) -> None:
+        "set current self.text and tokenization to text"
        try:
            try:
-                arg0, maybe_json = self.text.split(" ", 1)
-                assert json.loads(self.text)
+                arg0, maybe_json = text.split(" ", 1)
+                assert json.loads(maybe_json)
                self.tokens = maybe_json.split(" ")
            except (json.JSONDecodeError, AssertionError):
                # replace quote
-                clean_quote_text = self.text
+                clean_quote_text = text
                for quote in unicode_quotes:
                    clean_quote_text.replace(quote, "'")
                arg0, *self.tokens = shlex.split(clean_quote_text)
        except ValueError:
-            arg0, *self.tokens = self.text.split(" ")
+            arg0, *self.tokens = text.split(" ")


@itdaniher , this is a questionable part of this pr

* add ask_intable and ask_floatable abstractions, do_challenge * refactoring and cleanup to simplify out common patterns, also add a bunch of docs * black * missing bits * lil more lint * missing format * lint * black Co-authored-by: infra <infra@sterile.solutions>

* adds kinda graphical captcha * black * Update Pipfile * Don't require 3.8. Co-authored-by: infra <infra@sterile.solutions>

Co-authored-by: infra <infra@sterile.solutions>

* port fixes and expansions from the hotline; add signalme, rot13, recipients-store parsing, better error handling to sending payments * fixups * add missing import Co-authored-by: infra <infra@sterile.solutions>

* parens * more detailed types Co-authored-by: infra <infra@sterile.solutions>

…ctor hostname

* refactor load_secrets to make it easier to manipulate secrets files * NO_DOWNLOAD->DOWNLOAD, NO_MEMFS->AUTOSAVE with `no` being the default. LOGLEVEL defaults to DEBUG. ROOT_DIR defaults to . if not DOWNLOAD * cleanup, incorporating some changes from #26 / #108 * include gitignore, symlink dockerignore * fix moved imports * fix githook instruction * try adding a unit test? * nicer ci step names

* Changed get address to let you specify an FS_ACCOUNT NAME in secrets * changed handle payment and payment response to move the default message to payment response * changed the demo to be more straightforward * added which envvars to set * final version for the tutorial * more stuff * things changed cause black * merge get_account_id_by_name and get_account, rename Mobster.get_address to get_my_address, add error handling in case of invalid FS_ACCOUNT_NAME, rename Bot.get_address to get_signalpay_address * added a call that was missing * made finished example match * minor changes for consistency * black * s/get_address/get_signalpay_address/ in mobfriend and contact, a few simplifications and type fixes * edited to pass linters * fixed some more linter things, only on the code from this PR tho * incorporated all comments from the PR * black * idk what's going on with mobfriend metrics * fix missed changes * remove references to changed flags and add a type hint to account_id * Rename echopay_final.py to echopay_fully_implemented.py * Rename echopay.py to echopay_template.py * Rename echopay_fully_implemented.py to echopay.py * add changelog notes Co-authored-by: transfaeries <transfaeries@gmail.com> Co-authored-by: infra <infra@sterile.solutions> Co-authored-by: technillogue <technillogue@gmail.com> Co-authored-by: itdaniher <itdaniher@gmail.com>

…eadme with root readme (#142)

* stick SIGNAL_PATH with shutil.which in utils

* stick SIGNAL_PATH with shutil.which in utils * fix

* writeup Imposter description and problem statement * working config file, set in dev_secrets * got dependencies working somehow * update gitignore for poetry * add typing notification * respond to mentions or quotes * add Ranker for examples and facts * update for new ReaderAgent in personate * add read_url command * add emoji reacts and replies * add acrossword dependency for serving local ranker * fix group_id * clean reply so we don't get chicken emoji * add a bot that can track reply chains and reactions * fix lints * add sending quotes and a test command * working MemoryBot implementation * small fixes on imposter * typing and refactor * comments and docstrings * pass correct bot * give imposter a nemory * comments on reply function * get facts from conversation history * replace example bot with PKD * add installation instructions to README * bump ci cache lock (#192) * bump cache * update deps * update gitignore * remove ipython dep * actually look for ROOT_DIR * format (sigh) * add mobot config * dockerize and upload to fly * remove pipfile * update to new version of phonenumbers Co-authored-by: technillogue <technillogue@gmail.com>

…roups she's added to. (#213) * Initial commit * this should be done * do gg * bepdicted the whitelist added methods * black * fix type errors * fix lints from new pylint version * missed await in hotline Co-authored-by: transfaeries <transfaeries@gmail.com> Co-authored-by: technillogue <technillogue@gmail.com>

…o -002

transfaeries requested a review from technillogue January 11, 2022 19:40

transfaeries mentioned this pull request Jan 11, 2022

Imogen Priority Queue #77

Open

transfaeries linked an issue Jan 11, 2022 that may be closed by this pull request

Imogen Priority Queue #77

Open

transfaeries removed a link to an issue Jan 11, 2022

Imogen Priority Queue #77

Open

technillogue force-pushed the imogen-postgres branch 2 times, most recently from 819085b to 0900517 Compare January 21, 2022 06:43

itdaniher approved these changes Jan 31, 2022

View reviewed changes

technillogue reviewed Feb 1, 2022

View reviewed changes

technillogue and others added 22 commits February 16, 2022 20:50

copyright

53866a8

Adds graphical captcha prototype (#124)

9394901

* adds kinda graphical captcha * black * Update Pipfile * Don't require 3.8. Co-authored-by: infra <infra@sterile.solutions>

silence error (#126)

d306cbd

Co-authored-by: infra <infra@sterile.solutions>

Small fixes from Hotline (#129)

c0f1d57

* port fixes and expansions from the hotline; add signalme, rot13, recipients-store parsing, better error handling to sending payments * fixups * add missing import Co-authored-by: infra <infra@sterile.solutions>

fix logic error in requires_first_device

9d26cd5

Captcha command info

56a24f2

don't mind me (#136)

9d0d7dc

* parens * more detailed types Co-authored-by: infra <infra@sterile.solutions>

use socket.gethostname over /etc/hostname (#137)

e4bfa07

update Pipfile and add Dockerfile + Pipfile.lock to sample_bots; refa…

536900d

…ctor hostname

drop prometheus-async type ignores (should fix #133)

6365351

long overdue changelog update

d59edea

remove references to NO_MEMFS and NO_DOWNLOAD in docs; sync contact r…

e5b695c

…eadme with root readme (#142)

black githook only formats python files that are checked in

bb71bd2

stick SIGNAL_PATH with shutil.which in utils (#145)

6ef7fc7

* stick SIGNAL_PATH with shutil.which in utils

fix set_note

e133cf4

add coverage to ci

266c873

fix signal client that gets symlinked when running locally (#120)

6f18986

* stick SIGNAL_PATH with shutil.which in utils * fix

upsampling

d2ae6c8

unused

c075670

technillogue and others added 24 commits May 1, 2022 22:28

update diffusion

0ba1722

fix dialog

cc5fdf6

add tweet_id column

98b93cb

typo

80d38b3

Update pdict docs (#215)

4caab4f

bump?

86432a2

add chaos group thing for detecting and reacting to good posts

1ff8875

score_info and image bumps

1035830

merge main and drop unused self.sent_messages

32e570c

add _good commands and image bumps; enable and debug safe mode

91769e3

set signal-cli buffer limit to 1mb over 64kb; safe mode ren

f86c182

for some reason the right logging got fucked up?

9236c14

admin allowlist

efc83e7

fix admins safe mode?

a077b2a

factor out prompts, hopefully fix admin stuff, and bump instructgpt t…

55ec60f

…o -002

finetuned gpt

507127f

add dalle and think about pl_imogen.sql

e60874e

downgrade proto

c9b1735

include dalle.yaml

9e1b57e

describe

a3ee5bf

allow admin to say naughty words

7e5525a

factor out word denylist

0b63c4c

jgreat force-pushed the main branch 3 times, most recently from cd0757b to 395d3b9 Compare April 10, 2023 22:17

jgreat force-pushed the imogen-postgres branch from 4f41f18 to 0b63c4c Compare April 10, 2023 22:48

jgreat closed this Apr 11, 2023

jgreat deleted the imogen-postgres branch April 11, 2023 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Priority Queue Implementation for Imogen #76

Priority Queue Implementation for Imogen #76

transfaeries commented Jan 11, 2022 •

edited by sync-by-unito bot

Loading

itdaniher left a comment

itdaniher Jan 31, 2022

technillogue Jan 31, 2022

technillogue Jan 31, 2022

itdaniher Jan 31, 2022

technillogue Feb 1, 2022

itdaniher Jan 31, 2022

technillogue Feb 1, 2022

itdaniher Jan 31, 2022

technillogue Jan 31, 2022

itdaniher Jan 31, 2022

technillogue Feb 1, 2022

itdaniher Jan 31, 2022

technillogue Feb 1, 2022

technillogue Feb 1, 2022

		@@ -0,0 +1,48 @@
		FROM ghcr.io/rust-lang/rust:nightly as builder

Priority Queue Implementation for Imogen #76

Priority Queue Implementation for Imogen #76

Conversation

transfaeries commented Jan 11, 2022 • edited by sync-by-unito bot Loading

itdaniher left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

transfaeries commented Jan 11, 2022 •

edited by sync-by-unito bot

Loading