EDGECLOUD-5233 create appinst fails fqdn prefix invalid DNS name #1623
Conversation
There was a problem hiding this comment.
The code looks good. I can see new RootLBs will pickup the new naming convention.
But what do we do for existing cloudlets that rootLbs already running? We only create DNS records when the rootLB is created, if it already exists it will not execute the code that does the DNS record creation. We may need to either run the DNS record code for existing rootLbs on startup somehow, but ideally just once (might be hard to track that)
Actually Jim, I believe it's ok. Vmlayer platform Init() calls SetupRootLB whether or not the rootLB already existed, and that updates the DNS entry. So if it's an old CRM, based on the compatibility version, the Controller will continue to use the old DNS name in the URI. If it's a new CRM, then when the CRM is started, it will update the DNS entry to the new name, and the Controller will start using the new name in the URI. |
oh you're right, I was thinking the code exited before doing this, but I guess not. So the only question is dedicated LBs, but maybe that is not worth worrying about as the big majority of the time the AppInst is created at the same time as the cluster. edit dedicated format isn't changing anyway and so doesn't matter |
|
Cool, thanks for reviewing Jim! |
Issues Fixed
Description
Changes corresponding to edge-cloud PR: mobiledgex/edge-cloud#1403
The changes here make it so CreateAppDNSAndPatchKubeSvc does not issue DNS records for kubernetes services that don't have their own IP. To remove the double negative: only kubernetes services that are issued their own IP for platforms like GCP/Azure/etc, will issue a DNS record for the service name (fqdn prefix + uri).