Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor default ints in cad code #118

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Conversation

a-mosquito
Copy link
Contributor

No description provided.

@a-mosquito a-mosquito linked an issue Mar 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (0396404) to head (4c2138d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files          55       55           
  Lines        2628     2628           
=======================================
  Hits         2400     2400           
  Misses        228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-mosquito
Copy link
Contributor Author

Not only .astype(int) is problematic, but also integer numpy arrays that are converted to Dataframes later. dtype="int64" needs to be specified when constructing them as well, since otherwise the OS-specific default int type will be inferred.

@AKuederle
Copy link
Contributor

Awesome! Quick question, why did that result in two new regression files?

@a-mosquito
Copy link
Contributor Author

Awesome! Quick question, why did that result in two new regression files?

I think I accidentally created them while playing around with the test cases...they were identical to the original ones and are not created anymore when running the tests, so I removed them

@AKuederle AKuederle merged commit d039acb into main Mar 26, 2024
11 checks passed
@AKuederle AKuederle deleted the 117-snapshots-fail-under-windows branch March 26, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshots Fail under Windows
2 participants