-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions about common FP functions #7
Comments
hey @anthony-khong 👋 thanks for your questions!
I'd be more than grateful if you could create something like this! ❤️ |
ad 2. it's been fixed and published in |
Hi @mobily, thank you very much for the response! And thank you for the patch to address (2)!
Absolutely, I've started looking into this. I realised though a lot of the functions I would love to use are not yet implemented, so I'm thinking of working on that first. If you're open to suggestions, would you accept contributions for Clojure's equivalent of If you agree to some of these proposals, I'd just like to make sure what it takes to implement these functions. I would have to implement the functions in |
that’s actually a good point in terms of the naming convention, I took the
the function names you posted look good to me. I'm only wondering if
yes, the only downside is that you need to rebuild the lib each time when you made changes (I need to rethink how to make this process more developer-friendly) |
I'm happy to change this on my latest PR (#8). Having a set of coherent function names is quite nice.
The experience is okay for now. I can think of a couple of things that may be improved on top of my head:
I'm curious to know what you actually do during development! |
👋 hey again @anthony-khong!
I did some changes to improve this process, so basically, for development purposes, you can use the following commands: yarn build dev -n Dict -t set ⬆️ this command will build a single module (in this case yarn test run -f set -n Dict ⬆️ this command will be useful if you change a single test file (in this case |
Hi @mobily, I'd just like to get your thoughts on something. I'm thinking about implementing
Questions are:
|
this is related to #25, I will let you know once I figure it out |
closing, |
Hi @mobily, the library looks really interesting! I'm quite interested in trying it out for future projects. I just have a couple of questions about certain functions, and I hope this is the right place to ask.
assoc
anddissoc
withts-belt
? Would it have to beD.merge(m, {k: v})
andD.rejectWithKey(m, (_, key) => key == k)
?D.xxxWithKey
's signature is(v, k)
instead of the usual (or rather what I would expect to be)(k, v)
. Is that just a matter of personal preference or rather a convention from another library/language that I'm not familiar with?ts-belt
does eager evaluation? So something like, say,pipe(m, D.toPairs, A.take(2))
would iterate through all the key-value pairs first before taking the first two elements?Also, something like Remeda's mapping doc would be very helpful to newcomers! I'm happy to chip in if you think it'd be useful.
The text was updated successfully, but these errors were encountered: