Enable BMS transformations to be written to the same .h5 file #90
Conversation
|
@moble can you look at this quick? It should be easy. |
scri/__version__.py
Outdated
| @@ -1 +1 @@ | |||
| __version__ = "2022.8.8" | |||
| __version__ = "2022.8.10" | |||
There was a problem hiding this comment.
What versioning is scri using? It looks like calendar versioning, so shouldn't this be 2024.02.21?
There was a problem hiding this comment.
Yeah idk what git is doing here; it does this "bump" automatically right after I push a commit
There was a problem hiding this comment.
Unfortunately, I tried CalVer for a while, before realizing I really needed SemVer, but now we're stuck with major versions like 2022...
But the automatic bumping should only happen on release commits to main. Are you saying that this change and the CITATION.cff change were not your doing?
There was a problem hiding this comment.
Yeah this was done automatically by git; maybe it's because I'm committing to my fork's main?
There was a problem hiding this comment.
Ah, that makes sense. I'll adjust that condition.
[Enable BMS transformations to be written to the same .h5 as a group. This will be used for the SXS catalog, i.e., storing multiple BMS transformations in one "BMS.h5" file.