Improving RulesEndpointProvider exception when tried to use SDK with …

…unmapped store or environment
mobly · Aug 28, 2015 · 8e37c11 · 8e37c11
1 parent 1716e94
commit 8e37c11
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 6 deletions.
diff --git a/src/Common/RulesEndpointProvider.php b/src/Common/RulesEndpointProvider.php
@@ -52,7 +52,9 @@ public function __invoke(array $args = [])
             }
         }
 
-        throw new UnresolvedEndpointException();
+        throw new UnresolvedEndpointException(
+            'Could not resolve a valid endpoint to ' . $args['store'] . '-' . $args['environment']
+        );
     }
 
     /**

diff --git a/src/Version.php b/src/Version.php
@@ -11,7 +11,7 @@
 class Version
 {
 
-    const VERSION_NUMBER = '1.8.8';
+    const VERSION_NUMBER = '1.8.9';
 
     const API = '2.6';
 

diff --git a/tests/Common/RulesEndpointProviderTest.php b/tests/Common/RulesEndpointProviderTest.php
@@ -25,19 +25,33 @@ public function endpointProvider()
         return [
             [
                 ['store' => 'mobly-br', 'environment' => 'staging'],
-                ['endpoint' => 'https://sellercenter-api-staging.mobly.com.br', 'signatureVersion' => 'v1']
-            ]
+                ['endpoint' => 'https://sellercenter-api-staging.mobly.com.br', 'signatureVersion' => 'v1'],
+                true
+            ],
+            [
+                ['store' => 'unmapped-store', 'environment' => 'production'],
+                ['endpoint' => null, 'signatureVersion' => null],
+                false
+            ],
         ];
     }
 
     /**
      * @dataProvider endpointProvider
      */
-    public function testResolvesEndpoints($input, $output)
+    public function testResolvesEndpoints($input, $output, $valid)
     {
         // Use the default endpoints file
         $p = RulesEndpointProvider::fromDefaults();
-        $this->assertEquals($output, call_user_func($p, $input));
+        if ($valid) {
+            $this->assertEquals($output, call_user_func($p, $input));
+        } else {
+            $this->setExpectedException(
+                'SellerCenter\SDK\Common\Exception\UnresolvedEndpointException',
+                'Could not resolve a valid endpoint to ' . $input['store'] . '-' . $input['environment']
+            );
+            call_user_func($p, $input);
+        }
     }
 
     /**