Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume image format in put_photo #44

Closed
honi opened this issue Aug 17, 2012 · 3 comments
Closed

Don't assume image format in put_photo #44

honi opened this issue Aug 17, 2012 · 3 comments

Comments

@honi
Copy link

honi commented Aug 17, 2012

Right now the SDK doesn't check the actual image format, and assumes it's a JPG: https://github.com/pythonforfacebook/facebook-sdk/blob/master/facebook.py#L261
@honi honi mentioned this issue Aug 17, 2012
Closed
@dipen30
Copy link

dipen30 commented Sep 10, 2012

fix for this issue.

dipen30/facebook-sdk@f38a9cc

@honi
Copy link
Author

honi commented Sep 10, 2012

From my testing, Facebook doesn't care about the extension in the filename, but just for clarity, it would be nice if the filename had the correct extension based on the mimetype.

Here: dipen30/facebook-sdk@f38a9cc#L0R258

This was referenced Dec 16, 2012
Closed
Closed
@martey
Copy link
Member

martey commented Jun 1, 2013

Closing in favor of #61.

@martey martey closed this as completed Jun 1, 2013
vicondo26 pushed a commit to vicondo26/f that referenced this issue May 5, 2024
@dipen30
Update facebook.py
f38a9cc 
fixed the issue 
mobolic/facebook-sdk#44

Guessing mime type from file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martey @honi @dipen30