Add appsecret_proof support #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martey is there any hope in getting this merged soon? It's quite important for better security of setups with mobile apps, which may pass access tokens to the server. If there's something missing in the PR I'm happy help patching it up. |
|
I'd help too! Docs are the most important. |
|
I'd like to see automated tests and updated documentation before merging this. |
|
@dimitrovskif Are you planning on updating this PR, or do you need help? |
cleder
added a commit
to PrimarySite/facebook-sdk
that referenced
this pull request
Oct 14, 2016
cleder
pushed a commit
to PrimarySite/facebook-sdk
that referenced
this pull request
Nov 1, 2016
|
Closing in favor of #321, which includes tests. |
thieman
pushed a commit
to thieman/facebook-sdk
that referenced
this pull request
Mar 7, 2018
add tests and documentation, pep8 dimitrovskif changes to add appsecret_proof support mobolic#243 use hexdigest add tests pep8 add documentation remove spaces around keyword / parameter equals python 2 conditional install in one line
thieman
pushed a commit
to thieman/facebook-sdk
that referenced
this pull request
Mar 7, 2018
add tests and documentation, pep8 dimitrovskif changes to add appsecret_proof support mobolic#243 use hexdigest add tests pep8 add documentation remove spaces around keyword / parameter equals python 2 conditional install in one line
thieman
pushed a commit
to thieman/facebook-sdk
that referenced
this pull request
Mar 7, 2018
add tests and documentation, pep8 dimitrovskif changes to add appsecret_proof support mobolic#243 use hexdigest add tests pep8 add documentation remove spaces around keyword / parameter equals python 2 conditional install in one line Duplicated this in rebase
DmytroLitvinov
pushed a commit
to softformance/facebook-sdk
that referenced
this pull request
Aug 13, 2019
add tests and documentation, pep8 dimitrovskif changes to add appsecret_proof support mobolic#243 use hexdigest add tests pep8 add documentation remove spaces around keyword / parameter equals python 2 conditional install in one line Duplicated this in rebase
DmytroLitvinov
pushed a commit
to softformance/facebook-sdk
that referenced
this pull request
Aug 13, 2019
add tests and documentation, pep8 dimitrovskif changes to add appsecret_proof support mobolic#243 use hexdigest add tests pep8 add documentation remove spaces around keyword / parameter equals python 2 conditional install in one line Duplicated this in rebase
DmytroLitvinov
pushed a commit
to softformance/facebook-sdk
that referenced
this pull request
Aug 13, 2019
add tests and documentation, pep8 dimitrovskif changes to add appsecret_proof support mobolic#243 use hexdigest add tests pep8 add documentation remove spaces around keyword / parameter equals python 2 conditional install in one line Duplicated this in rebase
DmytroLitvinov
pushed a commit
to softformance/facebook-sdk
that referenced
this pull request
Aug 13, 2019
add tests and documentation, pep8 dimitrovskif changes to add appsecret_proof support mobolic#243 use hexdigest add tests pep8 add documentation remove spaces around keyword / parameter equals python 2 conditional install in one line Duplicated this in rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for secure Graph API calls with the
appsecret_proofGET param (or POST ifpost_args). Described hereThis PR successfully fixes #213, which was good but rejected because it wasn't PEP8 compliant and the argument wasn't positioned correctly (new argument last for compatibility).