Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for accept_ms_testers_without_closed_task #41

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

philippeauriach
Copy link
Member

@philippeauriach philippeauriach commented Feb 1, 2023

What does it do? Why?

馃憠馃徎 On a few repositories, such as @mobsuccess-devops/mobsuccess , it is necessary to be able to merge PRs without the corresponding Asana task being closed.

This PR adds compatibility with this :

The repo must have a mobsuccess.yml file at root with the following content:

asana:
  accept_ms_testers_without_closed_task: true

And the PR must be assigned to @ms-testers

Good To Know

馃憠馃徎 https://mobsuccess.slack.com/archives/C031L5J9F96/p1675262014282969

@ms-bot
Copy link
Contributor

ms-bot commented Feb 1, 2023

A review for this PR has been requested in Slack #mobsuccess-review-requested 馃憠 https://mobsuccess.slack.com/archives/C02FDSTH4SE/p1675270531328579

action.js Outdated Show resolved Hide resolved
@ms-bot
Copy link
Contributor

ms-bot commented Feb 1, 2023

A review for this PR has been requested in Slack #mobsuccess-review-requested 馃憠 https://mobsuccess.slack.com/archives/C02FDSTH4SE/p1675295652899089?thread_ts=1675270531.328579&cid=C02FDSTH4SE

Copy link
Contributor

@etienne-mobsuccess etienne-mobsuccess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: gillesperrin <gillesperrin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants