Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update who's using MobX list #20

Merged
merged 4 commits into from
Jul 14, 2017
Merged

Update who's using MobX list #20

merged 4 commits into from
Jul 14, 2017

Conversation

hawkins
Copy link
Member

@hawkins hawkins commented Jul 12, 2017

Fixes #8

cc @mweststrate


Still todo:

  • Add images to README-CN.md?
  • Decide whether or not we should port USERS.md to Chinese. (cc @SangKa )

Josh Hawkins and others added 4 commits July 10, 2017 22:37
Quitting because its late and the groundwork is laid :) tomorrow!

Next: mobxjs/mobx#681 (comment)
Tried to be closer to actual sources and only force the outliers to be height 128
@hawkins
Copy link
Member Author

hawkins commented Jul 12, 2017

I'm not convinced the users doc is worth translating yet, since that will probably be a frequent update and infrequent reference. Since the information in the later entries is so informal anyways, it seems like there isn't quite enough value in it to maintain the document across multiple languages; maybe just rely on Google Translate or similar for that? Thoughts, @SangKa ?

That being said I think it'd be good to add the same "Who's using MobX" logo block to the CN doc, but link to USERS.md. I can do that part, of course.

@SangKa
Copy link
Contributor

SangKa commented Jul 12, 2017

Got it, I will follow up.
README.md will navigate to the USERS.md as normal.
README-CN.md will navigate to the USERS-CN.md which is a translation version of USERS.md.

@hawkins
Copy link
Member Author

hawkins commented Jul 12, 2017

I'm worried that would lead to more frequent work than you'd like, but since you're cool with it for now, that sounds great. Thanks! 👍

@SangKa
Copy link
Contributor

SangKa commented Jul 12, 2017

I'm cool ~

@hawkins hawkins merged commit fe4db39 into master Jul 14, 2017
@hawkins hawkins deleted the using branch July 14, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants