Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Karma with Jest, run tests on CI (#87) #101

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Replace Karma with Jest, run tests on CI (#87) #101

merged 2 commits into from
Dec 9, 2019

Conversation

kubk
Copy link
Contributor

@kubk kubk commented Dec 8, 2019 •
edited
Loading

Related issue: #87

  • Karma test runner was replaced with Jest
  • Fixed lint errors in ng2-mobx.spec.ts
  • Added tests to CI

@adamkleingit adamkleingit merged commit 07b0b79 into mobxjs:master Dec 9, 2019
@kubk
Copy link
Contributor Author

kubk commented Dec 9, 2019

Hi @adamkleingit What do you think about running Prettier across entire project? Currently tslint is complaining about double quotes, that's why I replaced them with single quotes. Can make a PR. Thank you.

@adamkleingit
Copy link
Member

Yeah I'm all for it, thanks! We should use husky and lint-staged to ensure it runs on commit automatically.
Here is an example from our company's boilerplate:
https://bitbucket.org/500tech/react-redux-project-boilerplate/src/master/package.json

@kubk kubk mentioned this pull request Jan 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kubk @adamkleingit