New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/137/v12 v13 support #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 0 B |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamkleingit I've separated migration to small portions.
Angular v13 is now working with mobx newest version.
Fully tested.
However, I was forced to add to bank-v13 application the following:
makeAutoObservable(this);
Full snippet under account.store.ts:
Without it it wouldn't work.
I found the solution in this example: reactions.
Also, it seems like
autorun
is not encouraged with class component. Source: stackoverflowI need a clarification on this one.
If everything seems legit, then I'll update the README as well with this new use case.
What am I missing here?
Thanks ahead.
Edit (06/11/2021): As I suspected, @EVASIVE suggested the same in his PR: #138
I'll update README