Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 15 support #171

Merged
merged 1 commit into from Jan 24, 2023
Merged

Angular 15 support #171

merged 1 commit into from Jan 24, 2023

Conversation

modus-jose
Copy link

@modus-jose modus-jose commented Dec 6, 2022

@EVASIVE can you help me test, projects that upgrade are blocked by enforcing peer dependencies

@SimonMcKinsey
Copy link
Member

@modus-jose Thank you for your PR.
I'll have a look at it.

@Whylandos
Copy link

please add angular 15 support
npm ERR! peer @angular/common@">=11.1.1 <15.0.0" from mobx-angular@4.6.0
npm ERR! node_modules/mobx-angular
npm ERR! mobx-angular@"4.6.0" from the root project

@kaemmi84
Copy link

I also need angular 15 support.

@Mas2112
Copy link

Mas2112 commented Jan 18, 2023

I have tested mobx-angular on Angular 15 with my fairly large project. So far our E2E tests and our manual tests have not found any issues. Can we get this PR merged?

@SimonMcKinsey SimonMcKinsey merged commit 716ab0c into mobxjs:master Jan 24, 2023
@SimonMcKinsey
Copy link
Member

Merged.
I will publish it later today/tomorrow.

@michermd
Copy link

Hello @SimonTouitou any update?

@michermd
Copy link

Hello @SimonTouitou can you provide a timeframe for the publication?

@Chuckv01 Chuckv01 mentioned this pull request Jan 25, 2023
@Chuckv01
Copy link
Contributor

This version has been published to npm.

@Whylandos
Copy link

Thank you.

It does not seem to work, sadly.

Angular 15 & different node / npm versions I tried.

Cannot find module 'mobx-angular' or its corresponding type declarations.

@modus-jose
Copy link
Author

modus-jose commented Jan 26, 2023

@Whylandos I get the same error from the version published @Chuckv01

@Chuckv01
Copy link
Contributor

🤦 Sorry folks - didn't run npm publish from the dist directory. 4.7.1 should fix that issue.

@Whylandos
Copy link

it works

thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants