Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root project for Angular 15 support #179

Merged
merged 22 commits into from Mar 17, 2023
Merged

Conversation

sagarchikane
Copy link
Contributor

@sagarchikane sagarchikane commented Feb 21, 2023

Things taken care of as part of this PR

  • Root project package.json updates to support Angular 15 (Angular 16 release schedule) and latest Angular Material
  • Project can be built with Node 18
  • Many automated updates were done by following the Angular guide
  • Fixed unit tests
  • Fixed warning for CUSTOM_ELEMENTS_SCHEMA when running tests
  • Updated Karma configurations
  • Updated Github actions to fix deprecations

Copy link
Contributor

@Chuckv01 Chuckv01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI failed when trying to run these changes: https://github.com/mobxjs/mobx-angular/actions/runs/4234842254/jobs/7360174315

Side note: Can we get https://github.com/mobxjs/mobx-angular/blob/master/.github/workflows/main.yml updated to run the project unit tests / linting?

@Chuckv01
Copy link
Contributor

Copy link
Contributor

@Chuckv01 Chuckv01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skips execution of unit tests on example projects

package.json Outdated Show resolved Hide resolved
@Chuckv01 Chuckv01 merged commit 0b7c999 into mobxjs:master Mar 17, 2023
@Chuckv01
Copy link
Contributor

The compare bundle sizes step is failing here as the master branch is failing to compile on the newer version of node. Shouldn't be an issue on future PRs as master will now have updated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants