-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for Maintainer Help and Official Support #9
Comments
Awesome proposal,will be glad to help with! 😃 |
Hey guys, I will gladly add you as maintainers. |
Added the two of you. |
Awesome thanks so much! I also am having second thoughts about renaming anything. I think it is just best to leave everything as |
Hey cool initiatives @nickbreaton & @kuitos ! Moving is fine with me. @adamkleingit I think you should already have the permissions to move it. Otherwise invite me as collaborator, then I can probably move it |
Moved to https://github.com/mobxjs/ng1-mobx |
Done
Op ma 22 jan. 2018 om 10:01 schreef adam klein <notifications@github.com>:
… Moved to https://github.com/mobxjs/ng1-mobx
But now I don't have admin permissions on it so I can't add collaborators
/ change its name to mobx-angularjs. @mweststrate
<https://github.com/mweststrate> can you make me admin?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhGDCi0jrdfyfYMI8K66SEM8--0DUks5tNE5GgaJpZM4RgvqI>
.
|
A great evolution for mobx-angularjs! |
@kuitos I think that might be the better solution so that the name stays consistent for users. I will update the package name and repository URL in the PR. @mweststrate Thanks for weighing in! 😄 |
@adamkleingit @nickbreaton Added you two as |
Great. I deprecated ng-mobx |
Hello @adamkleingit.
This library has proven useful to me in the past few days. I hope to get my company to use it soon in order to ease a transition from AngularJS to React. I appreciate the time you put into it.
I had a few issues and noticed that @kuitos had forked and fixed most of them. It seems that you may not have had the time or desire to keep up with the maintenance of this project to merge them back in, #5, which is totally understandable when you are busy maintaining something like mobxjs/mobx-angular. I, on the other hand, do not have any open source projects to maintain and would love to help out.
If you are up for it, I propose that we make a few changes:
We could possibly move the repo under the mobxjs organization as
mobxjs/mobx-angularjs
, cc @mweststrate.Deprecate ng-mobx on npm, and align it with the same naming convention as mobx-angular, publishing under
mobx-angularjs
, if that is okay with @kuitos.Align the codebase with the conventions of
mobx-angular
and incorporate changes made by @kuitos. I have done this here and will gladly submit a PR.Cheers!
The text was updated successfully, but these errors were encountered: