Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Maintainer Help and Official Support #9

Closed
nickbreaton opened this issue Jan 17, 2018 · 11 comments
Closed

Proposal for Maintainer Help and Official Support #9

nickbreaton opened this issue Jan 17, 2018 · 11 comments

Comments

@nickbreaton
Copy link
Contributor

nickbreaton commented Jan 17, 2018

Hello @adamkleingit.

This library has proven useful to me in the past few days. I hope to get my company to use it soon in order to ease a transition from AngularJS to React. I appreciate the time you put into it.

I had a few issues and noticed that @kuitos had forked and fixed most of them. It seems that you may not have had the time or desire to keep up with the maintenance of this project to merge them back in, #5, which is totally understandable when you are busy maintaining something like mobxjs/mobx-angular. I, on the other hand, do not have any open source projects to maintain and would love to help out.

If you are up for it, I propose that we make a few changes:

  1. We could possibly move the repo under the mobxjs organization as mobxjs/mobx-angularjs, cc @mweststrate.

  2. Deprecate ng-mobx on npm, and align it with the same naming convention as mobx-angular, publishing under mobx-angularjs, if that is okay with @kuitos.

  3. Align the codebase with the conventions of mobx-angular and incorporate changes made by @kuitos. I have done this here and will gladly submit a PR.

Cheers!

@kuitos
Copy link
Member

kuitos commented Jan 17, 2018

Awesome proposal,will be glad to help with! 😃

@adamkleingit
Copy link
Member

Hey guys, I will gladly add you as maintainers.
It's up to @mweststrate whether to put this in the main org. I think it will be less confusing for developers that way.

@adamkleingit
Copy link
Member

Added the two of you.
Thanks for the contribution!

@nickbreaton
Copy link
Contributor Author

Awesome thanks so much! I also am having second thoughts about renaming anything. I think it is just best to leave everything as ng-mobx.

@mweststrate
Copy link
Member

Hey cool initiatives @nickbreaton & @kuitos !

Moving is fine with me. @adamkleingit I think you should already have the permissions to move it. Otherwise invite me as collaborator, then I can probably move it

@adamkleingit
Copy link
Member

Moved to https://github.com/mobxjs/ng1-mobx
But now I don't have admin permissions on it so I can't add collaborators / change its name to mobx-angularjs. @mweststrate can you make me admin?

@mweststrate
Copy link
Member

mweststrate commented Jan 22, 2018 via email

@kuitos
Copy link
Member

kuitos commented Jan 22, 2018

A great evolution for mobx-angularjs!
Do you think is it necessary to publish it under mobx-angularjs on npm from then on? @nickbreaton @adamkleingit

@nickbreaton
Copy link
Contributor Author

@kuitos I think that might be the better solution so that the name stays consistent for users. I will update the package name and repository URL in the PR.

@mweststrate Thanks for weighing in! 😄

@kuitos
Copy link
Member

kuitos commented Jan 23, 2018

@adamkleingit @nickbreaton Added you two as mobx-angularjs package collaborators.

@adamkleingit
Copy link
Member

Great. I deprecated ng-mobx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants