Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove peerDependencies #45

Closed
wants to merge 1 commit into from

Conversation

Strate
Copy link

@Strate Strate commented Oct 17, 2016

It is hard to use pre-release versions of mobx & mobx-react with this requirements.
See also npm/npm#8854 (comment)

It is hard to use pre-release versions of mobx & mobx-react with this requirements.
See also npm/npm#8854 (comment)
@Strate
Copy link
Author

Strate commented Oct 20, 2016

@mweststrate what do you think about it? Can I merge?

@mweststrate
Copy link
Member

Hmm not entirely sure about this one. It makes sure the minimum versions of the required api's are available. Violating peer deps is only a warning afaik in both npm 2 and 3 if you already provided the dependency yourself in the parent package? (which you should)

@Strate
Copy link
Author

Strate commented Oct 20, 2016

Unfortunatelly, that warning breaks shrinkwrap - shrinkwrap didn't write if unmet peer dependency.
Yet another one way to fix it - is to publish according version of this package, which includes pre-release version in peerDependency. Which is hard to maintain :(.

@mweststrate
Copy link
Member

It is definitely annoying to use a pre release with these in place, but I think this is the correct thing to.

For now I just copy the folder contents manually when trying to test a fresh version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants