[CustomType] Add 'environment' as second argument for options.fromSnapshot #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviergonz
approved these changes
Oct 29, 2019
mweststrate
requested changes
Oct 29, 2019
mweststrate
approved these changes
Oct 31, 2019
|
Released as 3.16.0. Terribly sorry for the late follow up! Do ping me next time if this is annoying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like a common case to modify
custom-type's value using environment, i.e. for mocking dates in tests or using i18n.This PR makes it possible via passing current tree's environment as second argument to the
fromSnapshotmethod.Initially I tried to pass
parent- but it'sObjectNodewhich is non-conventional for MST (we ususally do not pass bare nodes to userland). My second attempt was to passparent.storedValue(which isIAnyStateTreeNodeand is more common), but it'sundefinedby the time we callfromSnapshotand we can not call.valueeither as we are actually in the middle of the observable node creation.So the only valid option left is to pass at least the environment itself.
Typedoc edited.
Test added.