Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mobx-state-tree): use reduce instead of forEach #1802

Merged
merged 3 commits into from Dec 4, 2021
Merged

refactor(mobx-state-tree): use reduce instead of forEach #1802

merged 3 commits into from Dec 4, 2021

Conversation

rluvaton
Copy link
Contributor

No description provided.

@rluvaton
Copy link
Contributor Author

It turns out to look more complicated than before 🤨, WDYT?

I changed .forEach to reduce as this is a classical .reduce usage

@jamonholmgren jamonholmgren merged commit f3ed574 into mobxjs:master Dec 4, 2021
@jamonholmgren
Copy link
Collaborator

Nice. I like reduce.

@jamonholmgren
Copy link
Collaborator

Released in https://github.com/mobxjs/mobx-state-tree/releases/tag/v5.1.0

@rluvaton rluvaton deleted the patch-3 branch December 5, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamonholmgren jamonholmgren jamonholmgren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rluvaton @jamonholmgren