Add two new primitives for MST #2052
Conversation
Added: - A float type, which would restrict against NaN. - A finite type, which would restrict against NaN and infinities
There was a problem hiding this comment.
Hey @chakravarthi-bb - thank you for this! Looks great.
Would you mind also updating the docs site with these changes? The API change that got auto generated in your PR is useful, but I think we also need to update the Primitive types section in docs/overview/types.md.
Let me know once you've done that, I'll take another look, and we should be good to go. I think we'll get this in the next minor release, but I'm not exactly sure when that'll be (hopefully soon).
|
Hey @chakrihacker - just a heads up that I merged an older PR adding Thanks! |
|
I will update this week |
|
@coolsoftwaretyler Can you review please? |
There was a problem hiding this comment.
@chakrihacker - thanks for the good work and the rebase!
I'm going to make two small commits against this PR to fix some docs, but other than that, I'm going to approve it, merge it, and get it out for the alpha build of the next minor release (hopefully tonight).
| @@ -116,6 +118,44 @@ export const integer: ISimpleType<number> = new CoreType<number, number, number> | |||
| (v) => isInteger(v) | |||
| ) | |||
|
|
|||
| /** | |||
| * `types.float` - Creates a type that can only contain an float value. | |||
| * This type is used for float values by default | |||
There was a problem hiding this comment.
| * This type is used for float values by default |
nitpick: @chakrihacker - this is not technically true, I don't think we infer types.float for floating point numbers. I think this comment is true of types.number, based on how getPrimitiveFactoryFromValue behaves, which is what we call in toPropertiesObject when doing type inference.
I'm going to make this edit since it's small and really more of a nitpick than anything.
|
|
||
| /** | ||
| * `types.finite` - Creates a type that can only contain an finite value. | ||
| * This type is used for finite values by default |
There was a problem hiding this comment.
nitpick: @chakrihacker - this is not technically true, I don't think we infer types.finite with this change. I think this comment is true of types.number, based on how getPrimitiveFactoryFromValue behaves, which is what we call in toPropertiesObject when doing type inference.
I'm going to make this edit since it's small and really more of a nitpick than anything.
Added:
closes #1960