Convert to bun:test for our tests, remove codecov #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to get this working with a little bit of bash scripting. I don't love it, but since the Bun test runner doesn't behave precisely like The major downside right now is that coverage is no longer correctly generated. I will see if I can fix that up. Bun also shipped support for |
coolsoftwaretyler
force-pushed
the
test/convert-to-bun-test-module
branch
from
c53f899
to
9298488
Compare
coolsoftwaretyler
changed the title
|
I added the specific I also removed |
coolsoftwaretyler
force-pushed
the
test/convert-to-bun-test-module
branch
from
432b9c3
to
f7e47ea
Compare
coolsoftwaretyler
added a commit
that referenced
this pull request
Apr 17, 2024
* chore: include bun types for tests, fix ts config * test: fix expected literal for bun runtime in test * test: fix circular tests * test: bump snapshot for bun testing * test: fix Frozen to expect Bun errors rather than Node * test: remove inline snapshot error assertions for bun * chore: remove a comment * test: bump reference-custom snapshots for Bun * chore: remove unused import * test: use toJSON to assert equality on proxy object * test: migrate action tracking middleware2 test to bun * test: update async test for bun test runner * test: fix object-node test for bun test runner * chore: remove Jest and related packages * test: import bun:test, fix type errors * test: import bun test * test: import bun test helpers to array test * test: add bun test imports to async test * test: add bun test imports to boolean * test: add bun test imports to boxes-store * test: add bun imports, fix errors to custom-type test * test: import bun test helpers, fix erros in date test * test: add bun test imports to deprecated test * test: add bun test imports to enum test, fix errors * test: use bun test imports, fix errors in env test * test: use bun test imports for frozen test * test: import bun test, fix hooks * test: import bun test utilities, fix errors in identifier * test: use bun imports for jsonpatch test * test: use bun test imports, fix errors in late test * test: import bun test helpers to lazy * test: import bun test helpers, fix errors in literal test * test: use bun test imports, fix ts error in map test * test: import bun test helpers, fix errors in model test * test: use bun test imports for name test * test: import bun test helpers to node test, fix issues * test: import bun test helpers, fix issues in number test * test: add bun test helpers and fix ts issues in object test * test: use bun test imports in optimizations test * test: import bun test helpers, fix ts issues with optional extension * test: import bun test utilities to optional test * test: import bun test utiltities to parent properties * test: import bun test utilties to pointer * test: ipmort bun test helpers to primitives * test: import bun test helpers to protect test * test: add bun test imports for recordPatches * test: import bun test utilities to reference-custom * test: use bun test utilities, fix undefined issues * test: use bun test helpers in reference test * test: use bun test utilities in refinement test * test: use bun test helpers for reflection test * test: use bun test utilities in snapshotProcessor * test: import bun test utilities and fix tyeps for string test * test: use bun test helpers in this test * test: use bun test utilities, fix ts error in type system test * test: use bun test helpers, fix ts errors * test: add bun test helpers to volatile test * test: core tests work with skips * test: skip perf tests temporarily * test: simplify package.json testing scripts for bun * chore: simplify bun testing in CI * chore: remove codecov step for now * spike: add a utility to reset action id for tests - should think about this more * test: fix ~100 skipped tests * test: narrow down to one problematic test in model * test: only skip 47 tests now * spike: try runnig all tests on their own, almost works * test: get bun test:all to work * test: no mor eneed for resetActionId * test: bring back expect.assertions * test: remove codecov * fix: missing fail declaration * test: add back specific error message tests * test: ensure bun tests scripts exit when failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
This PR will convert our Jest test to bun test. This offers us a few advantages:
ts-jestts-jestandjestitself, we reduce ourdevDependenciesas wellMstErrorfrom a rebaseSteps to validate locally
bun installbun test:all- tests should pass.time bun test:all, you can measure its runtime. Here's what I got on my 2020 Macbook Pro with Intel i7/32 GB RAM:Compare this to the
yarn test:allrun inmaster, which reports:Ran it with
time yarn test:alland got slightly better results but with a lot more CPU usage: