Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not mutate properties object by model constructor #2176

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: do not mutate properties object by model constructor #2176

merged 1 commit into from
Apr 16, 2024

Conversation

dangreen
Copy link
Contributor

fixes #2175

@dangreen dangreen marked this pull request as draft April 16, 2024 13:23
@dangreen dangreen marked this pull request as ready for review April 16, 2024 13:56
coolsoftwaretyler
coolsoftwaretyler approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@coolsoftwaretyler coolsoftwaretyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the bug report and quick PR.

I'll merge this in and ship it with a patch version soon. We have another incoming bug fix that should get merged shortly. I expect to have things out by the end of the week.

__tests__/core/model.test.ts Show resolved Hide resolved
@coolsoftwaretyler coolsoftwaretyler merged commit 7b7602a into mobxjs:master Apr 16, 2024
1 check passed
@dangreen dangreen deleted the fix-2175 branch April 16, 2024 15:36
coolsoftwaretyler pushed a commit that referenced this pull request Apr 17, 2024
@dangreen @coolsoftwaretyler
fix: do not mutate properties object by model constructor (#2176)
5f63509 
fixes #2175
coolsoftwaretyler pushed a commit that referenced this pull request Apr 17, 2024
@dangreen @coolsoftwaretyler
fix: do not mutate properties object by model constructor (#2176)
0ebde86 
fixes #2175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolsoftwaretyler coolsoftwaretyler coolsoftwaretyler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model constructor modifies descriptor object
2 participants
@dangreen @coolsoftwaretyler