Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ValueProperty and other cleanups #304

Closed
wants to merge 3 commits into from

Conversation

mattiamanzati
Copy link
Contributor

@mattiamanzati mattiamanzati commented Aug 17, 2017

  • deprecate ValueProperty
  • optimization: persist properties names in array to iterate easily
  • added check for views return
  • object will no longer initialize undefinedType under the hood
  • Node snapshot reaction will initialize after node is finalized

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 95.842% when pulling 43ac089 on no-more-this-mm into abbb19e on no-more-this.

@mattiamanzati
Copy link
Contributor Author

@mweststrate Feel free to merge if everything is ok, codecov -0.06 I think is acceptable :P

@mweststrate
Copy link
Member

mweststrate commented Aug 17, 2017 via email

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 96.0% when pulling c564621 on no-more-this-mm into abbb19e on no-more-this.

@mattiamanzati
Copy link
Contributor Author

Closing to retarget master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants