Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use interfaces wherever possible, they compile/parse faster #945

Merged
merged 2 commits into from Jul 26, 2018
Merged

use interfaces wherever possible, they compile/parse faster #945

merged 2 commits into from Jul 26, 2018

Conversation

xaviergonz
Copy link
Contributor

@xaviergonz xaviergonz commented Jul 25, 2018

this small pull request is to change some types to interfaces wherever possible, since they are compiled/parsed faster by TS

@xaviergonz xaviergonz changed the title use interfaces wherever possible, they compile faster use interfaces wherever possible, they compile/parse faster Jul 25, 2018
@xaviergonz
Copy link
Contributor Author

while at it also converted the last tests files that were in js to ts

@mweststrate
Copy link
Member

@xaviergonz ok, let me know when you are comfortable with the changes!

@xaviergonz
Copy link
Contributor Author

xaviergonz commented Jul 25, 2018 via email

@mweststrate mweststrate merged commit 40e7778 into mobxjs:master Jul 26, 2018
@mweststrate
Copy link
Member

Thanks!

@xaviergonz xaviergonz deleted the ts-faster-typings branch August 25, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants