Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please export StreamListener<T> #143

Closed
thejohnfreeman opened this issue Aug 18, 2018 · 2 comments
Closed

Please export StreamListener<T> #143

thejohnfreeman opened this issue Aug 18, 2018 · 2 comments

Comments

@thejohnfreeman
Copy link

fromStream returns { current: T, dispose(): void }, which is awkward to type, so I create my own type alias for it, but would rather just import the right one from mobx-utils. I'd be happy to contribute this, but I have some questions.

StreamListener has some more stuff in it than just current and dispose, which themselves aren't even marked public.

  1. Do you want me to separate current and dispose into their own interface?
  2. Do you oppose me marking them public?
@mweststrate
Copy link
Member

mweststrate commented Aug 18, 2018 via email

mweststrate added a commit that referenced this issue Sep 4, 2018
@mweststrate
Copy link
Member

Released as 5.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants