You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fromStream returns { current: T, dispose(): void }, which is awkward to type, so I create my own type alias for it, but would rather just import the right one from mobx-utils. I'd be happy to contribute this, but I have some questions.
StreamListener has some more stuff in it than just current and dispose, which themselves aren't even marked public.
Do you want me to separate current and dispose into their own interface?
Do you oppose me marking them public?
The text was updated successfully, but these errors were encountered:
fromStream returns { current: T, dispose(): void }, which is awkward to
type, so I create my own type alias for it, but would rather just import
the right one from mobx-utils. I'd be happy to contribute this, but I have
some questions.
StreamListener has some more stuff in it than just current and dispose,
which themselves aren't even marked public.
1. Do you want me to separate current and dispose into their own
interface?
2. Do you oppose me marking them public?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#143>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhJldJxHyaRlDvTVhKc1dir1M1VxOks5uSA5jgaJpZM4WCjxl>
.
fromStream
returns{ current: T, dispose(): void }
, which is awkward to type, so I create my own type alias for it, but would rather just import the right one from mobx-utils. I'd be happy to contribute this, but I have some questions.StreamListener
has some more stuff in it than justcurrent
anddispose
, which themselves aren't even markedpublic
.current
anddispose
into their own interface?public
?The text was updated successfully, but these errors were encountered: