Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ensure ES6 observable getters are included in createViewModel #188

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Fix: ensure ES6 observable getters are included in createViewModel #188

merged 1 commit into from
Apr 17, 2019

Conversation

wrench7
Copy link

@wrench7 wrench7 commented Apr 2, 2019

This should fix the issues discussed here #100 (comment)

@wrench7
Copy link
Author

wrench7 commented Apr 2, 2019 •
edited

Worth pointing out that the function for returning all properties and prototype methods is taken from https://stackoverflow.com/a/47714550

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.28% when pulling 5d147c1 on wrench7:es6-getters-create-view-model into ecb5e84 on mobxjs:master.

@mweststrate mweststrate merged commit 5d147c1 into mobxjs:master Apr 17, 2019
@mweststrate
Copy link
Member

Thanks, merged! Will release soon

@mweststrate
Copy link
Member

Released as 5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wrench7 @coveralls @mweststrate