Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have transformer not memorize when called outside reactive context #228

Merged
merged 1 commit into from Jan 13, 2020
Merged

have transformer not memorize when called outside reactive context #228

merged 1 commit into from Jan 13, 2020

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Nov 29, 2019

This should fix #116.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.761% when pulling 887d928 on upsuper:transformer-not-memorize-outside into c2f9b42 on mobxjs:master.

@upsuper
Copy link
Contributor Author

upsuper commented Nov 29, 2019

This is definitely going to conflict with #224 though 😂

@mweststrate mweststrate merged commit 887d928 into mobxjs:master Jan 13, 2020
@mweststrate
Copy link
Member

Released as 5.5.3

@upsuper upsuper deleted the transformer-not-memorize-outside branch January 13, 2020 19:25
@realyze realyze mentioned this pull request Jun 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createTransformer leaks memory when run outside a reactive context
3 participants
@upsuper @coveralls @mweststrate